From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by sourceware.org (Postfix) with ESMTPS id D0B4B382E82D for ; Fri, 23 Apr 2021 15:06:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D0B4B382E82D Received: by mail-qk1-x733.google.com with SMTP id 8so16135921qkv.8 for ; Fri, 23 Apr 2021 08:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4/gj/WBzMAQCKO99htNn7c1n4g2jzckobw4g+yCxbGI=; b=VXQCZ6TWSqjHQAunxwLn41iJw8G8cxtXQmsfrvOKwgGUSH4X0EeJH6+k6tdCL4h4tm V7xiFytbwoPSl1MOHxKQThLtGPsSrFrozUjLPin26ALQeH2YTX6s9gqlm5Za7lmOhFh5 Yr4GHCwjVtkWaB+LT1qF0IkMEk27RV+8b/ik7NpPvzLUeeyAe/zdXG/1vfW5ZDIPNQuh DE41OkRX6xuG3VueqafNovtW1B87yUn7RWxJe1J8SVKI/Zk1OJ2s9FKgF0lMvv5B0Pxi lspT6xMrLVaEYW3QU7S/EKTa4MIJpOuch2bchxM8RUIaOweRERrbFjGpCRqdFHvFQaaE f2BA== X-Gm-Message-State: AOAM533Wb0YrwkLQdX1uopepskyyVGMALBjO2JoKq+jKWgjOL5hRES/F iV9OlIqS5XcDo7qk4+GkIvk= X-Google-Smtp-Source: ABdhPJwvsJLpza4aVCzR2mrzG3vAqnxbi+oNuVTqWuCDjnMLx9GZqnT8uzufdpcCyHjKDUDfSVDnnw== X-Received: by 2002:a05:620a:13ca:: with SMTP id g10mr4334324qkl.380.1619190406508; Fri, 23 Apr 2021 08:06:46 -0700 (PDT) Received: from [192.168.0.41] (71-218-14-121.hlrn.qwest.net. [71.218.14.121]) by smtp.gmail.com with ESMTPSA id d204sm4506001qke.3.2021.04.23.08.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 08:06:46 -0700 (PDT) Subject: Re: [PATCH] more out of bounds checking improvements To: Florian Weimer , Martin Sebor via Libc-alpha Cc: Joseph Myers References: <176ba75f-4299-073f-8319-66dbf9fe3f42@gmail.com> <87k0ot9trs.fsf@oldenburg.str.redhat.com> From: Martin Sebor Message-ID: Date: Fri, 23 Apr 2021 09:06:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87k0ot9trs.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 15:06:48 -0000 On 4/23/21 4:31 AM, Florian Weimer wrote: > * Martin Sebor via Libc-alpha: > >> diff --git a/sysdeps/gnu/net/if.h b/sysdeps/gnu/net/if.h >> index e587a5ce59..30f3e281e5 100644 >> --- a/sysdeps/gnu/net/if.h >> +++ b/sysdeps/gnu/net/if.h >> @@ -191,7 +191,9 @@ __BEGIN_DECLS >> >> /* Convert an interface name to an index, and vice versa. */ >> extern unsigned int if_nametoindex (const char *__ifname) __THROW; >> -extern char *if_indextoname (unsigned int __ifindex, char *__ifname) __THROW; >> +extern char *if_indextoname (unsigned int __ifindex, >> + char __ifname[IF_NAMESIZE]) __THROW >> + __attr_access ((__write_only__, 2)); >> >> /* Return a list of all interfaces and their indices. */ >> extern struct if_nameindex *if_nameindex (void) __THROW; > > Is the change from a pointer to an array allowed by POSIX? There's no way for a conforming program to tell how a function pointer parameter is declared so I believe it is. Martin