From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 5252A384402F for ; Fri, 3 Jul 2020 20:23:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5252A384402F Received: by mail-qk1-x742.google.com with SMTP id c30so25945233qka.10 for ; Fri, 03 Jul 2020 13:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/gkd7Jg8BRDti3SDeoeGE4itSzyv2eoSMTar7iMA+mM=; b=jxSPOUTgGqJPDFKjOaGlH5E8otTZc+LLek3oRDCdw0bZR+QUd3l6zzL+yhM/1a/osJ 786j2wtJnNmhCJeUTTDrJvU6b5GUO6Rge0I66X0a+YnkCIjqlqAZZwDEO58zrATsU9Y0 fo2H2mSlKsB5hWQbciqcrrCeWzqcFZGP53bThV8hfmS8QtynlV9HYCAH2VjIndTzqFy2 /48KtNZ+4Gy0DmRfq82WJwHYz0WDnX7FGqD5V+1oY6VW46WAb1dnZ3bOROlxqYRYZ2VJ 5y0L6tMpfborE7SPtXIdQlMgSpoza1eZx0UpbmO9M7YE5LI0f9FUNG8nAeBQmRH5XSt9 9fRA== X-Gm-Message-State: AOAM531zeMbbUvlQmniFDKsSKdRJvIWNq2LsjPNa+Ua/Ox3o+9Rd2133 hYwE+htzctZ5qv1hZcT4j+f475kU7fk= X-Google-Smtp-Source: ABdhPJxryDF2TVDEdDzB8UXRbfbwvk5xUPja2glQeN1xsBSBoKveMenTcNzGYnPiAiqxNXPOG59+IA== X-Received: by 2002:a37:4d8:: with SMTP id 207mr36846909qke.298.1593807835698; Fri, 03 Jul 2020 13:23:55 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id h185sm11334824qkf.85.2020.07.03.13.23.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 13:23:55 -0700 (PDT) To: Carlos O'Donell , libc-alpha@sourceware.org References: <20200619134352.297146-1-adhemerval.zanella@linaro.org> <20200619134352.297146-12-adhemerval.zanella@linaro.org> <05744028-6434-5c9f-7498-12965f0b793c@redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH v5 12/13] string: Add sigabbrev_np and sigdescr_np Message-ID: Date: Fri, 3 Jul 2020 17:23:52 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <05744028-6434-5c9f-7498-12965f0b793c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 20:23:58 -0000 On 02/07/2020 18:13, Carlos O'Donell wrote: > On 6/19/20 9:43 AM, Adhemerval Zanella wrote: >> The sigabbrev_np returns the abbreviated signal name (i.g. "HUP" for >> SIGHUP) while sigdescr_np returns string describing error number > > s/returns string/returns the string/g > s/ error/ the error/g Ack. > >> (i.g "Hangup" for SIGHUP). Different than strsignal, sigdescr_np >> does not attempt to translate the return description and both >> functions return NULL for an invalid signal number. >> >> They should be used instead of sys_siglist or sys_sigabbrev and they >> are both thread and async-signal safe. They are added as GNU >> extensions on string.h header (same as strsignal). > > These are perfect functions to use in place of sys_siglist and > sys_sigabbrev. Thus we now have functions to access the old data in > a way that avoids exposing the data to COPY relocations (and the > size encoded in that ABI). Thanks for fixing this up. > >> Checked on x86-64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu, >> and s390x-linux-gnu. > > OK for master if you accept the manual suggestions and commit message > changes. Done, I also extended a bit the release wiki with a simple example on how to use these interfaces. > > No regressions on x86_64 and i686. > > Tested-by: Carlos O'Donell > Reviewed-by: Carlos O'Donell > >> >> diff --git a/NEWS b/NEWS >> index ec39b6e056..f504772eb6 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -31,6 +31,16 @@ Major new features: >> pthread_attr_getsigmask_np have been added. They allow applications >> to specify the signal mask of a thread created with pthread_create. >> >> +* The functions sigabbrev_np and sigdescr_np have been added. The >> + sigabbrev_np returns the abbreviated signal name (i.g. "HUP" for SIGHUP) >> + while sigdescr_np returns string describing signal number (i.g "Hangup" > > s/returns string/returns a string/g > s/ signal/ the signal/g Ack. > >> + for SIGHUP). Different than strsignal, sigdescr_np does not attempt >> + to translate the return description and both functions return NULL for >> + an invalid signal number. >> + >> + They should be used instead of sys_siglist or sys_sigabbrev and they >> + are both thread and async-signal safe. These functions are GNU extensions. > > OK. > >> + >> Deprecated and removed features, and other changes affecting compatibility: >> >> * The deprecated header and the sysctl function have been >> diff --git a/include/signal.h b/include/signal.h >> index 3d6315b741..b4ee02d153 100644 >> --- a/include/signal.h >> +++ b/include/signal.h >> @@ -16,7 +16,8 @@ libc_hidden_proto (__libc_current_sigrtmin) >> libc_hidden_proto (__libc_current_sigrtmax) >> extern const char * const __sys_siglist[_NSIG]; >> libc_hidden_proto (__sys_siglist) >> - >> +extern const char * const __sys_sigabbrev[_NSIG]; >> +libc_hidden_proto (__sys_sigabbrev) > > OK. > >> >> /* Now define the internal interfaces. */ >> extern __sighandler_t __bsd_signal (int __sig, __sighandler_t __handler); >> diff --git a/include/string.h b/include/string.h >> index ce01ad8254..f4ce138622 100644 >> --- a/include/string.h >> +++ b/include/string.h >> @@ -53,6 +53,9 @@ extern char *__strerror_r (int __errnum, char *__buf, size_t __buflen); >> >> extern char *__strerror_l (int __errnum, locale_t __loc); >> >> +extern const char *__sigdescr_np (int __errnum); >> +libc_hidden_proto (__sigdescr_np) > > OK. > >> + >> /* Get _STRING_ARCH_unaligned. */ >> #include >> #endif >> diff --git a/manual/signal.texi b/manual/signal.texi >> index 34def1c06c..a19dff85f8 100644 >> --- a/manual/signal.texi >> +++ b/manual/signal.texi >> @@ -880,6 +880,30 @@ to @var{signum}. >> This function is a BSD feature, declared in the header file @file{signal.h}. >> @end deftypefun >> >> +@deftypefun void sigdescr_np (int @var{signum}) >> +@standards{GNU, string.h} >> +@safety{@prelim{}@mtsafe{@mtssigintr{}}@assafe{}@acsafe{}} > > Use @mtsafe{}, because the function does not touch _sigintr at all. Ack. > >> +This function returns the message describing the signal @var{signum} or >> +@code{NULL} for invalid signal number (i.g "Hangup" for @code{SIGHUP}). > > s/i.g/e.g./g Ack. > >> +Different than @code{strsignal} the returned description is not translated. >> +The message porints to a static storage whose lifetime is the whole lifetime > > s/porints/points/g ACk. > >> +of the program. >> + >> +@pindex string.h >> +This function is a GNU extension, declared in the header file @file{string.h}. >> +@end deftypefun >> + >> +@deftypefun void sigabbrev_np (int @var{signum}) >> +@standards{GNU, string.h} >> +@safety{@prelim{}@mtsafe{@mtssigintr{}}@assafe{}@acsafe{}} > > Use @mtsafe{}, because the function does not touch _sigintr at all. Ack. > >> +This function returns the abbreviation describing the signal @var{signum} or >> +@code{NULL} for invalid signal number. The message porints to a static > > s/porints/points/g Ack.