From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by sourceware.org (Postfix) with ESMTPS id B1C61394741A for ; Wed, 26 May 2021 17:29:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B1C61394741A Received: by mail-qk1-x735.google.com with SMTP id j189so1799867qkf.2 for ; Wed, 26 May 2021 10:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DqG2apJy1qtkHNaCeT/znL9WZb1aBC13bR8runlf7o4=; b=C6OpfTsuwRMiy8Mc8HCcVxitV7qftzhetu0NUtrQxSbSk9hH0vYI9yO5r9oF+E/h1H spSAlQ+2EDWwXlgyQH78QVSjdG7xTW9q2YO+vgNiVyumeJDSi5JaOeWs+/TnTfSWKhhL kXv3psVBpYFi59I3oQLYo6uQsFHFzRIjSx1t9dGXjprol4AJlcyrAwmK0kibt7njSJOb kZOeeZg9JJvDuwb/kbUVJltlp7kqpuVP08CFsD+m8ZyuPkSia6ZouWy4sLnO+Qs02P8F 09Lx1DVXrcq6OPw1lT2wNl+47rso8TlqF7Rc0QT4sbU0zQjHo79OoCgPWLI7sTfbtfMV PJQQ== X-Gm-Message-State: AOAM5308mk6rIK/1Fc7eEO0wyw3nQU13kwWL32RoN17hFMnKCJuCy5r+ F2BJlObjI/PAhOhTIdTtDboqrm5oBstK/Q== X-Google-Smtp-Source: ABdhPJy6kZ02nbo9f/Y2NjMv5lySu3gpyxj6k7t+2SZ1fmGYWThO8aiw2XSOfgvJOzE0P8+JPgbtrQ== X-Received: by 2002:a37:4697:: with SMTP id t145mr42166007qka.188.1622050188162; Wed, 26 May 2021 10:29:48 -0700 (PDT) Received: from [192.168.1.4] ([177.194.37.86]) by smtp.gmail.com with ESMTPSA id 2sm2009432qtr.64.2021.05.26.10.29.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 10:29:47 -0700 (PDT) Subject: Re: [PATCH 02/11] nptl: Move createthread to pthread_create To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210526165728.1772546-1-adhemerval.zanella@linaro.org> <20210526165728.1772546-3-adhemerval.zanella@linaro.org> <87sg29qutn.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Wed, 26 May 2021 14:29:45 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87sg29qutn.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 17:29:49 -0000 On 26/05/2021 14:16, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> The 'create_thread' function is moved to pthread_create.c. It removes >> the START_THREAD_DEFN and START_THREAD_SELF macros and make the >> lock usage more clear (no need to cross-reference multiple files). >> >> No functional change. > > Please remove the remaining references to the macros > > nptl/pthread_create.c: unlocks PD->lock which synchronizes-with START_THREAD_DEFN in the > nptl/pthread_create.c: createthread.c defines the macro START_THREAD_DEFN to the > nptl/pthread_create.c: START_THREAD_SELF to the expression to optimally deliver the new > > and commit this separately. Thanks. Ack, I will remove them.