From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id ACEEB3858404 for ; Thu, 1 Jun 2023 18:00:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACEEB3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6af7e368bb7so994388a34.1 for ; Thu, 01 Jun 2023 11:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685642400; x=1688234400; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gC8vjY+D1vq6dFaFo1TEHNG7gTHgb55EZ3CB7cEhIaM=; b=S6yBYFk22lzRHN6TzoI2AT2ndT67DCU2b7XJsQqeBbP5uin4wpnrXb1CEn8wadugf6 6Z6MuOPxWjpTPRYHOW+LLEMxhUI6D8c+McUn+OIURrdRUzCdj9emueQi1+OxEaDqTvcd JCiAxBXdrTcA4rSYJuUlYmhsGXiX8MySCT4q1lYX8b65vScCF5MdKhrlLI7WVmdxzxR4 zfj5i4qpAwAi4lMuE2B+xzN86484eG1BUwDBHh7y5ZFA8owJC+rIce6aatmj4FXGzSWt nOcRxuzijIKjVvau1nC+W6pEkvE/SEjHRpOiHhZhyhlCOI+RG/fSzZX2LXcK53++XBl+ Cczg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685642400; x=1688234400; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gC8vjY+D1vq6dFaFo1TEHNG7gTHgb55EZ3CB7cEhIaM=; b=fA80tFo3gn0XMj1rvo7gZlJM1EGZu5PFA2YkyM2ZCaotRUh8zl+MVIEuUBp9Q0yCcs mVOVI+TkPEwll9W3xJlKx5l3elM2j3OX5H7bH9VmsMGN9EUXAWM9ypsbEe4eGTbCfwuI gRUPiFSvCLeC7dXSEg+smmtYSO3AlC8e+USQDmm151Wd9O3FGpv2KxNl8QFu/8B6PDma vQWFl6nC+Vwvuv8lWp44tPCxQK1mykpdrFvSfCyK4u4s0blbpTnlmZdZPtYm0M1tT0U2 MXMTx58jbDGUZlCqpxC2rzrAkJ8wgJ1dm7H/fKD/kLFA8TfBkJQx69MvbLJoUswGWHVr 3+dw== X-Gm-Message-State: AC+VfDzWq6q22c2QOcbNbjUnWaVORF0XoCUkb1MKADPH9Lnv5eb0uJZR YFwnZIj7XSLTv95bU58u3Jaa0g== X-Google-Smtp-Source: ACHHUZ6G+EAvKttVT/c5t5ppFqrBWFQz0AXshsimxhJ6DP0NwjWie75w7tx2OzFmo7r06H/QUKt7LA== X-Received: by 2002:a9d:77d6:0:b0:6af:870c:b71b with SMTP id w22-20020a9d77d6000000b006af870cb71bmr156069otl.27.1685642400047; Thu, 01 Jun 2023 11:00:00 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:4dd5:cc5a:e3f0:42a7:4888? ([2804:1b3:a7c1:4dd5:cc5a:e3f0:42a7:4888]) by smtp.gmail.com with ESMTPSA id do26-20020a0568300e1a00b006aaf3e81baesm1769286otb.24.2023.06.01.10.59.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 10:59:59 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 14:59:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH v2 1/2] Fix invalid use of NULL in epoll_pwait2(2) test Content-Language: en-US To: Alejandro Colomar , libc-alpha@sourceware.org Cc: Alejandro Colomar References: <6c399f6b-6e89-17c4-2a56-1219a1b86448@linaro.org> <20230531204422.18052-1-alx@kernel.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230531204422.18052-1-alx@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31/05/23 17:44, Alejandro Colomar wrote: > epoll_pwait2(2)'s second argument should be nonnull. We're going to add > __nonnull to the prototype, so let's fix the test accordingly. We can > use a dummy variable to avoid passing NULL. > > Reported-by: Adhemerval Zanella Netto > Signed-off-by: Alejandro Colomar LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/unix/sysv/linux/tst-epoll.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/tst-epoll.c b/sysdeps/unix/sysv/linux/tst-epoll.c > index 66f091c202..abda45c427 100644 > --- a/sysdeps/unix/sysv/linux/tst-epoll.c > +++ b/sysdeps/unix/sysv/linux/tst-epoll.c > @@ -180,6 +180,8 @@ epoll_pwait2_check (int epfd, struct epoll_event *ev, int maxev, int tmo, > static int > do_test (void) > { > + struct epoll_event ev; > + > { > struct sigaction sa; > sa.sa_handler = handler; > @@ -191,7 +193,7 @@ do_test (void) > xsigaction (SIGCHLD, &sa, NULL); > } > > - int r = epoll_pwait2 (-1, NULL, 0, NULL, NULL); > + int r = epoll_pwait2 (-1, &ev, 0, NULL, NULL); > TEST_COMPARE (r, -1); > bool pwait2_supported = errno != ENOSYS; >