public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>, libc-alpha@sourceware.org
Subject: Re: [PATCH] free: preserve errno [BZ#17924]
Date: Sun, 20 Dec 2020 23:27:55 -0500	[thread overview]
Message-ID: <ad0ae4cb-ef86-1586-998c-c7de8ae94345@redhat.com> (raw)
In-Reply-To: <20201220202556.3714-1-eggert@cs.ucla.edu>

On 12/20/20 3:25 PM, Paul Eggert wrote:
> * malloc/Makefile (tests): Add tst-free-errno.
> * malloc/malloc.c (tcache_init): Preserve errno when initializing,
> since 'free' might be calling us.
> (__libc_free): Preserve errno when calling munmap.
> * malloc/tst-free-errno.c: New file, almost all from Bruno Haible.
> * manual/memory.texi (Freeing after Malloc, Replacing malloc):
> Document that free preserves errno.

Please provide a reasonable commit message.

-- 
Cheers,
Carlos.


  parent reply	other threads:[~2020-12-21  4:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20 20:25 Paul Eggert
2020-12-21  2:03 ` Siddhesh Poyarekar
2020-12-21  4:27 ` Carlos O'Donell [this message]
2020-12-21  7:20   ` Paul Eggert
2020-12-21  7:43     ` Siddhesh Poyarekar
2020-12-21  9:33     ` Florian Weimer
2020-12-21 10:03       ` Siddhesh Poyarekar
2020-12-21 10:05         ` Siddhesh Poyarekar
2020-12-23  5:30       ` Paul Eggert
2020-12-23 19:19         ` Adhemerval Zanella
2020-12-24  1:03           ` Paul Eggert
2020-12-28 19:24             ` Adhemerval Zanella
2020-12-29 13:38               ` H.J. Lu
2020-12-29 18:32                 ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad0ae4cb-ef86-1586-998c-c7de8ae94345@redhat.com \
    --to=carlos@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).