From: Paul Clarke <pc@us.ibm.com>
To: GNU C Library <libc-alpha@sourceware.org>,
Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
Subject: [PATCH][powerpc] Fix tiny bug in strncmp.c
Date: Tue, 15 Jan 2019 18:43:00 -0000 [thread overview]
Message-ID: <ad7190f2-a310-ae7e-8be3-7b460d9b372c@us.ibm.com> (raw)
A single underscore was omitted in
sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of
power8 version of strncmp instead of power9 version, with significant
performance degradation.
2019-01-15 Paul A. Clarke <pc@us.ibm.com>
* sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef.
diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
index ab7379d..d2791ce 100644
--- a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
+++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c
@@ -37,7 +37,7 @@ extern __typeof (strncmp) __strncmp_power9 attribute_hidden;
/* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
ifunc symbol properly. */
libc_ifunc_redirected (__redirect_strncmp, strncmp,
-# ifdef __LITTLE_ENDIAN_
+# ifdef __LITTLE_ENDIAN__
(hwcap2 & PPC_FEATURE2_ARCH_3_00)
? __strncmp_power9 :
# endif
next reply other threads:[~2019-01-15 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 18:43 Paul Clarke [this message]
2019-01-15 19:21 ` Adhemerval Zanella
2019-01-16 16:06 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7190f2-a310-ae7e-8be3-7b460d9b372c@us.ibm.com \
--to=pc@us.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).