From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C8B653858C32 for ; Wed, 10 Apr 2024 14:34:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8B653858C32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8B653858C32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712759690; cv=none; b=ropxzVIOcBLH3rNCDh6x0nyXEtATZcbNBJgqiagTDqWXfHhc+RpUp+AvglHpFJb6ZONKI1M7vGrZv7XGLyb6u4f7vycKDJHHuGGbBCOpEPtdLFEuh4on9PpsC6tejf76O3Uv9Xl6PEkuoapEfIgLqsE3g5B08gLe15/BH+N0078= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712759690; c=relaxed/simple; bh=RPHSI/S0MX9KhLpiIdjkTr9Lvzej0sWuHDUsicktEpw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=bo2boB9tYsSh3VXTkO2sWASIetzCFoTWVypyol1I3HIViTlrpOqEl1XBuzpH8Ppe3pYfqInVhc7vIgGjTiY2nciW5HE/TL73+j0f4yVBdhm81pNy+y2KlPXPnB3kZRzSwEG9Qha/X0Xf7f5GEWEc6TxNVg/5sxOxEj+p/5/SZZs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712759687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jJV9IAdEIsrSOHCBoRlILvRNrH0Xr/8hUyzI0OK+4Nk=; b=D8Mv/sWAM7eu0xOCkPdwqPCPCZDFtIRUk3o2Tv0UeHQvjdrncIh6XSABkRYvloTAyUDD+y Y7DzWsYDF1dEhbXdDLnLoYuHqErSK19sGSUjGAAtTZkaSynKUCo6T5eOoxePwm4k5agVdp UCuLE6sJcqM8e+0Pq0eVnzTIWfX+I5M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-n5Gb0b4nO2WQlrNF_x36Lw-1; Wed, 10 Apr 2024 10:34:46 -0400 X-MC-Unique: n5Gb0b4nO2WQlrNF_x36Lw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41401f598cfso39306045e9.2 for ; Wed, 10 Apr 2024 07:34:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712759685; x=1713364485; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jJV9IAdEIsrSOHCBoRlILvRNrH0Xr/8hUyzI0OK+4Nk=; b=godvAmzd6XLLRwTDMPEcSkZm2kS3CopsHi0AyFNtB/lSymWdAdxM6tCFLGjJ/2fzrf Pf2FZQW4l9WOu7urK5quqRNvoX2SmD/X/uVtpcCPV6OGlhaEx7RlyJZvqczZYHRGBP6q 2M9E5v3dN+ICQG6H6wX1NeSmb5q1LUeXCBjUKHUQReM+NaZREPLfVDiainQwSHgbX0Z9 arOKEI77SbiOpwuKOQ+SN3ujq4mMgKPJP33jeWrjGtFNrhvic6NksUS41L9ZMubOQVkz 12Rt08CswGs2qLXObN+ktOedDdh+ShVxef3+9wkeTBz4Od1cG1HnV0Qja/W+5TNY8bAh MQuA== X-Gm-Message-State: AOJu0YygzkyyZsPuZTItfKyGaw08zvOZlfogcuCl9YDJkstqNHARsnqX N+Fkpt2AucAKFNg4sK0mfbFBDbR7ebB+C9jby76zgCdSEblruEPjCA5eszE/t9u5SYhTKkTXt3Q ElMLZfbnoIiK9I7Wb8ANQi16rPXJamQaZ76ejIjhiL3oOoGPlATVAU0SENw== X-Received: by 2002:a05:600c:19cf:b0:416:fdb2:fa75 with SMTP id u15-20020a05600c19cf00b00416fdb2fa75mr1183458wmq.9.1712759685011; Wed, 10 Apr 2024 07:34:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQdgYuje4Wq3naP0MhFj2uchMBcTcErQjc7P1Z5lYFSEssW1iFVmFtlhj/Z7anx6sT0QmdpQ== X-Received: by 2002:a05:600c:19cf:b0:416:fdb2:fa75 with SMTP id u15-20020a05600c19cf00b00416fdb2fa75mr1183450wmq.9.1712759684676; Wed, 10 Apr 2024 07:34:44 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id p19-20020a05600c1d9300b00416bf7b68f6sm2454037wms.31.2024.04.10.07.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 07:34:44 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1ruZ1d-00By5T-FL; Wed, 10 Apr 2024 14:34:09 +0000 Date: Wed, 10 Apr 2024 14:34:09 +0000 (UTC) From: Joseph Myers To: Paul Zimmermann cc: libc-alpha@sourceware.org Subject: Re: Implement C23 log2p1 In-Reply-To: Message-ID: References: <41a4a6c9-4942-a9be-9459-1aaeb44ffee8@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 10 Apr 2024, Paul Zimmermann wrote: > Dear Joseph, > > I tried your patch on a x86_64, it applies cleanly, everything compiles > cleanly, and I can use the new log2p1 function in both binary32, binary64, > double-extended and binary128. > > As for accuracy, here are the largest errors I found for rounding to nearest: In general I encourage adding extra tests to auto-libm-test-in where they show errors, for any implementation in glibc, larger than those inputs already present (but not so large that they cannot be entered in libm-test-ulps files). So adding such inputs for log2p1 would be appropriate after this patch is in, and the same applies for all the other C23 functions as they get added. -- Joseph S. Myers josmyers@redhat.com