From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 220893858D26 for ; Mon, 22 Jul 2024 12:53:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 220893858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 220893858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721652792; cv=none; b=UUzTYDh/fEW9rESarvnDwpVCROR20waWm0W8luQaZTrNy4CltxPDpXtA04qaTUVbWHltT0LOiXUy8pbGYbT8nuk5INpxLMYW1nzsfnqzGd8umysymf56lai9s0mt/afWYvfYpajRfDG9EZMR13rqK3dJ3A566ZW09/Y5xBaqpio= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721652792; c=relaxed/simple; bh=Sn0kNkmpYFSTcakjVxp26CUATwuhaE5J5ikpj2DUGWk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=lkKpm82NKG8a86WNMRQaxqsT9AFjjf0f20y9SQTK+tDu18JDLeyVJhQ/2fP+v2YXWQShhUIa4VaSPn1LXvMswsOg5zr7GBMO0YxZoj8Jvf6j1spc+rmTUkKQqmj5KTdeV59sCVcdunhPxPcQAMISSlYrrBB7XhpFcgB59ovydUE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-7a03ada9660so865698a12.3 for ; Mon, 22 Jul 2024 05:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721652790; x=1722257590; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=TSWzLdqxpdYAsj1dmgr6T572KysbyCVRIjOQ9EvpjOk=; b=S7T6FKsLCgmqbyGGYMQhajcbj10HwIqhbC4WDcCH6DUa7En2jQZBHmnJ467DQnGChg ke50zjPj1hyaW1dR22P5QswqVupr3d8HDEuhgkAabX/lZwhiJNtVtl6Xcb9UgBfC7WYn LwBmqBd8/Xne7aAf1hDpstfcXoY1N96DfJMbEpN1bK4ui9H/4ruDr2B8eVjSf62kqZzU x2eMtT1JD5klqzP9T4ZpJfK1irtFuai0Y6aEoSwdMklX3jBLJCoPokuRWdyFBQuZ4CfH hNt+mzZagL+9RE2/RYeOZDdG5MMshikbIS8TtUffjLHxPg1dWneBNj6WYbouGui8Uc+Q KTFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721652790; x=1722257590; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TSWzLdqxpdYAsj1dmgr6T572KysbyCVRIjOQ9EvpjOk=; b=V1N9WtwSobsgRVkJEugN3w8ksy9MFtOJJdYl2TJOMUU4XQ8/xwfy4kdsCjCoYsKi6B enh15/vxVIjYhm1mPmAx4uefAPxhtAgXEkMwCLxCL6n7hnvZ5zPdd7QJHkhed0p7ljkl +TJLK22fe04+6zDtmWIqT4+4a/t2+1qyjcKmIXdHPHNE7fB/j7sBcJl4WI71ag3Htdwa DMhPH05K0xckeO/V/X5+nBAdnQ9e+r0Tun4SgPr7w9w13rDt6uvT/NxKxdWDejWR1kBo Mh5Q2YOw2pxtJYSN5W69h/dTGqdn36J0+b+i0tJBmjiL+4QDY1lMSHRWItWBN9vzUSQ9 FdQA== X-Forwarded-Encrypted: i=1; AJvYcCX5juzWbZGNGl/khZbyeGimJMZDYYEPkfQ9KH8KM0lwo1GWfn40eCxZ3NXFbyxUj+ebQcd3cJkmYXpmIXU5zNCprT6/K6eHApNk X-Gm-Message-State: AOJu0YzOuTjmM5QS8LMqfyyokUU2Dt/M+lXcpRAWoNw18bhpSubmB8Zr HXIzh9nIckQcIzULgFFAidocjSsz210uq7BriH/a4TPg7/6ZhCxwejwe+t9Ideh4o6pLFrAtGxX 3 X-Google-Smtp-Source: AGHT+IEM0SvbeEnkX37OB/SZt/UbRNvHrsiqeuHeMtk6KzarTXJjZSwKvb2MY3FXxN+NXJzveG7dCg== X-Received: by 2002:a05:6a21:c8a:b0:1c2:8949:5bc5 with SMTP id adf61e73a8af0-1c4285ba4e8mr4072943637.11.1721652789974; Mon, 22 Jul 2024 05:53:09 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:842a:2569:ada5:50e7:33d2? ([2804:1b3:a7c0:842a:2569:ada5:50e7:33d2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ccf80a8280sm6895072a91.48.2024.07.22.05.53.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jul 2024 05:53:09 -0700 (PDT) Message-ID: Date: Mon, 22 Jul 2024 09:53:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] debug: State buffer overflow message more precisely To: ZorA48gZxSHgPttS@quasitopos, libc-alpha@sourceware.org References: <2eb0c242-50cb-4209-b6dd-bf423d91634d@systemli.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <2eb0c242-50cb-4209-b6dd-bf423d91634d@systemli.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/07/24 09:41, Richard wrote: > Hi all, > > I've had a similar false positive a few weeks ago and just saw the post on the nixos github and this patch, would have saved me lots of debugging time. +1 > > Thanks, > -- Richard Which false positive to be more specific? Because this one was doing exactly what is intended, since the called does issues strlcpy with a 1-byte size buffer and relied on UB to get the buffer filled with data. In any case, this change does not make much sense with this rationale.