From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id F0B9C3858413 for ; Mon, 27 Mar 2023 17:54:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0B9C3858413 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1679939162; bh=HmZqFl22i5NwknYICngdlD3TmdllA+2gbmjIAxKSncs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=bNp/iGO0x9wRPBKuDDC+Iq3upsV1zf+YXwQZeOiEciZ+8+XR9mSRgSd37Xy8QJyp3 OdpLlkpMy2lDVNiwXiFRfQxhSF/HbJc1930UjuzQgx+YNXWRRx10EgzwwQ4H2s4N/y iibxyGVZeZJEI8cAmREUTvbHzOb814xBmpZt1pTw= Received: from localhost.localdomain (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 92BAA66326; Mon, 27 Mar 2023 13:46:01 -0400 (EDT) Message-ID: Subject: Re: [PATCH] LoongArch: ldconfig: Ignore EF_LARCH_OBJABI_V1 in shared objects From: Xi Ruoyao To: Adhemerval Zanella Netto , Carlos O'Donell , libc-alpha@sourceware.org Cc: caiyinyu , Wang Xuerui Date: Tue, 28 Mar 2023 01:46:00 +0800 In-Reply-To: References: <20230326111334.9920-1-xry111@xry111.site> <6f174ed1b3a54a83a8b0ff77fc0a50ceff2475a9.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-03-27 at 13:54 -0300, Adhemerval Zanella Netto wrote: > Since the boat is already sailed with 2.40, I think the proposed patch > is fine (it would be better if you indeed fix it on 2.41).=C2=A0 I would= =20 > just like to add a comment on why this is required: >=20 > =C2=A0 /* The EF_LARCH_OBJABI_V1 flag indicate which set of static reloca= tions > =C2=A0=C2=A0=C2=A0=C2=A0 the object might use and it only considered duri= ng static linking,=20 > =C2=A0=C2=A0=C2=A0=C2=A0 it does not reflect in runtime relocations.=C2= =A0 However some binutils=20 > =C2=A0=C2=A0=C2=A0=C2=A0 version might set it on dynamic shared object, s= o clear it to avoid=20 > =C2=A0=C2=A0=C2=A0=C2=A0 see the SO as unsupported.=C2=A0 */=20 Looks like Yinyu has already landed the patch. Yinyu: could you add this comment before the changed line? I don't have a write access. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University