From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cmx-mtlrgo002.bell.net (mta-mtl-001.bell.net [209.71.208.11]) by sourceware.org (Postfix) with ESMTP id 2E0E2385801E for ; Mon, 14 Feb 2022 15:25:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E0E2385801E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bell.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bell.net X-RG-CM-BuS: 0 X-RG-CM-SC: 0 X-RG-CM: Clean X-Originating-IP: [70.50.7.94] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 62060286003EA6C8 X-CM-Envelope: MS4xfJgzDSwiJEbVJY0ukQSxUzuW1aKqEI0qCx/BuFiMQo3CTmvwQksxiiu3BlvIeHGyquT+apHW2EnzoTODrLnkaOFciqXUHF+4tVRzvt3QxhykR6eUL9Dh DpJ923BfmLrsk/S5Xq6OqASsTBC560xbhE/kxzOMx1nVBkemvukzVfAD7p+Iv0e7U3XvKQaVvQ0kz0Rz44kKDYzuOYsE+qVCi7F/L7MVkkRC4v+Jv34As1P/ V9xPTBloy/BU83fqRA843FtpJ5eAxqvNU8EainEINO7fwvuiFEArBkssq94z5+Rm X-CM-Analysis: v=2.4 cv=aKWTFZxm c=1 sm=1 tr=0 ts=620a7464 a=9k1bCY7nR7m1ZFzoCuQ56g==:117 a=9k1bCY7nR7m1ZFzoCuQ56g==:17 a=r77TgQKjGQsHNAKrUKIA:9 a=FBHGMhGWAAAA:8 a=1Vy55DWHyD-eWeY8LhQA:9 a=QEXdDO2ut3YA:10 a=Ss4wsLoQE40erllVkn0A:9 a=De_Ol2h6w80A:10 a=9gvnlMMaQFpL9xblJ6ne:22 Received: from [192.168.2.49] (70.50.7.94) by cmx-mtlrgo002.bell.net (5.8.807) (authenticated as dave.anglin@bell.net) id 62060286003EA6C8; Mon, 14 Feb 2022 10:25:24 -0500 Content-Type: multipart/mixed; boundary="------------AALkclNdxA32MB4XPTMDm6jX" Message-ID: Date: Mon, 14 Feb 2022 10:25:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] rtld: Add new hook to initialize dp register on hppa Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, Carlos O'Donell References: <87r189s34l.fsf@oldenburg.str.redhat.com> <984f381f-fd37-12c9-599f-9e3b2d9a7d23@bell.net> <87bkzdrzmm.fsf@oldenburg.str.redhat.com> From: John David Anglin In-Reply-To: <87bkzdrzmm.fsf@oldenburg.str.redhat.com> X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2022 15:25:30 -0000 This is a multi-part message in MIME format. --------------AALkclNdxA32MB4XPTMDm6jX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2022-02-11 2:07 p.m., Florian Weimer wrote: >> Loading dp using from _rtld_local doesn't work till relocations are >> done.  Is there a way to compute main_map earlier? > You shouldn't need main_map for this. The link editor computes the > DT_PLTGOT and therefore knows the correct (relative) address. Your are correct.  The link editor does define the symbol $global$ at the start of the PLTGOT. However, I couldn't find a way to load its address without rummaging through the symbol table of main.  This is less efficient than using the PLTGOT value from the ELF header and main_map. I committed the attached change.  It doesn't need a new hook. Thanks, Dave -- John David Anglin dave.anglin@bell.net --------------AALkclNdxA32MB4XPTMDm6jX Content-Type: text/plain; charset=UTF-8; name="fix-audit2-v4.diff" Content-Disposition: attachment; filename="fix-audit2-v4.diff" Content-Transfer-Encoding: base64 Rml4IGVsZi90c3QtYXVkaXQyIG9uIGhwcGEKClRoZSB0ZXN0IGVsZi90c3QtYXVkaXQyIGZh aWxzIG9uIGhwcGEgd2l0aCBhIHNlZ21lbnRhdGlvbiBmYXVsdCBpbiB0aGUKbG9uZyBicmFu Y2ggc3R1YiB1c2VkIHRvIGNhbGwgbWFsbG9jIGZyb20gY2FsbG9jLiAgVGhpcyBvY2N1cnMg YmVjYXVzZQp0aGUgdGVzdCBpcyBub3QgYSBQSUMgZXhlY3V0YWJsZSBhbmQgY2FsbG9jIGlz IGNhbGxlZCBmcm9tIHRoZSBkeW5hbWljCmxpbmtlciBiZWZvcmUgdGhlIGRwIHJlZ2lzdGVy IGlzIGluaXRpYWxpemVkIGluIF9kbF9zdGFydF91c2VyLgoKVGhlIGZpeCBpcyB0byBtb3Zl IHRoZSBkcCByZWdpc3RlciBpbml0aWFsaXphdGlvbiBpbnRvCmVsZl9tYWNoaW5lX3J1bnRp bWVfc2V0dXAuICBTaW5jZSB0aGUgYWRkcmVzcyBvZiAkZ2xvYmFsJCBjYW4ndCBiZQpsb2Fk ZWQgZGlyZWN0bHksIHdlIGNvbnRpbnVlIHRvIHVzZSB0aGUgRFRfUExUR09UIHZhbHVlIGZy b20gdGhlCnRoZSBtYWluX21hcCB0byBpbml0aWFsaXplIGRwLgoKZGlmZiAtLWdpdCBhL3N5 c2RlcHMvaHBwYS9kbC1tYWNoaW5lLmggYi9zeXNkZXBzL2hwcGEvZGwtbWFjaGluZS5oCmlu ZGV4IGRhNGQ1N2QyZTQuLjdiN2E2OTdjYmIgMTAwNjQ0Ci0tLSBhL3N5c2RlcHMvaHBwYS9k bC1tYWNoaW5lLmgKKysrIGIvc3lzZGVwcy9ocHBhL2RsLW1hY2hpbmUuaApAQCAtMTc2LDYg KzE3NiwxNSBAQCBlbGZfbWFjaGluZV9ydW50aW1lX3NldHVwIChzdHJ1Y3QgbGlua19tYXAg KmwsIHN0cnVjdCByX3Njb3BlX2VsZW0gKnNjb3BlW10sCiAgICAgRWxmMzJfQWRkciBpWzJd OwogICB9IHNpZyA9IHt7MHgwMCwweGMwLDB4ZmYsMHhlZSwgMHhkZSwweGFkLDB4YmUsMHhl Zn19OwogCisgIC8qIEluaXRpYWxpemUgZHAgcmVnaXN0ZXIgZm9yIG1haW4gZXhlY3V0YWJs ZS4gICovCisgIGlmIChsLT5sX21haW5fbWFwKQorICAgIHsKKyAgICAgIHJlZ2lzdGVyIEVs ZjMyX0FkZHIgZHAgYXNtICgiJXIyNyIpOworCisgICAgICBkcCA9IERfUFRSIChsLCBsX2lu Zm9bRFRfUExUR09UXSk7CisgICAgICBhc20gdm9sYXRpbGUgKCIiIDogOiAiciIgKGRwKSk7 CisgICAgfQorCiAgIC8qIElmIHdlIGRvbid0IGhhdmUgYSBQTFQgd2UgY2FuIGp1c3Qgc2tp cCBhbGwgdGhpcy4uLiAqLwogICBpZiAoX19idWlsdGluX2V4cGVjdCAobC0+bF9pbmZvW0RU X0pNUFJFTF0gPT0gTlVMTCwwKSkKICAgICByZXR1cm4gbGF6eTsKQEAgLTMzOCwxNiArMzQ3 LDYgQEAgZWxmX21hY2hpbmVfcnVudGltZV9zZXR1cCAoc3RydWN0IGxpbmtfbWFwICpsLCBz dHJ1Y3Qgcl9zY29wZV9lbGVtICpzY29wZVtdLAogICAgaXRzIHJldHVybiB2YWx1ZSBpcyB0 aGUgdXNlciBwcm9ncmFtJ3MgZW50cnkgcG9pbnQuICAqLwogCiAjZGVmaW5lIFJUTERfU1RB UlQgXAotLyogU2V0IHVwIGRwIGZvciBhbnkgbm9uLVBJQyBsaWIgY29uc3RydWN0b3JzIHRo YXQgbWF5IGJlIGNhbGxlZC4gICovCVwKLXN0YXRpYyBzdHJ1Y3QgbGlua19tYXAgKiBfX2F0 dHJpYnV0ZV9fKCh1c2VkKSkJCQkJXAotc2V0X2RwIChzdHJ1Y3QgbGlua19tYXAgKm1hcCkJ CQkJCQlcCi17CQkJCQkJCQkJXAotICByZWdpc3RlciBFbGYzMl9BZGRyIGRwIGFzbSAoIiVy MjciKTsJCQkJCVwKLSAgZHAgPSBEX1BUUiAobWFwLCBsX2luZm9bRFRfUExUR09UXSk7CQkJ CQlcCi0gIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJyIiAoZHApKTsJCQkJCVwKLSAgcmV0dXJu IG1hcDsJCQkJCQkJCVwKLX0JCQkJCQkJCQlcCi0JCQkJCQkJCQlcCiBhc20gKAkJCQkJCQkJ CVwKICIJLnRleHRcbiIJCQkJCQkJXAogIgkuZ2xvYmwgX3N0YXJ0XG4iCQkJCQkJXApAQCAt NDQ3LDE0ICs0NDYsMTEgQEAgYXNtICgJCQkJCQkJCQlcCiAiCXN0dwklcjI0LC00NCglc3Ap XG4iCQkJCQlcCiAJCQkJCQkJCQlcCiAiLkxub2ZpeDpcbiIJCQkJCQkJCVwKKwkvKiBDYWxs IF9kbF9pbml0KG1haW5fbWFwLCBhcmdjLCBhcmd2LCBlbnZwKS4gKi8JCVwKICIJYWRkaWwJ TFQnX3J0bGRfbG9jYWwsJXIxOVxuIgkJCQkJXAogIglsZHcJUlQnX3J0bGRfbG9jYWwoJXIx KSwlcjI2XG4iCQkJCVwKLSIJYmwJc2V0X2RwLCAlcjJcbiIJCQkJCQlcCiAiCWxkdwkwKCVy MjYpLCVyMjZcbiIJCQkJCQlcCiAJCQkJCQkJCQlcCi0JLyogQ2FsbCBfZGxfaW5pdChfZGxf bG9hZGVkLCBhcmdjLCBhcmd2LCBlbnZwKS4gKi8JCVwKLSIJY29weQklcjI4LCVyMjZcbiIJ CQkJCQlcCi0JCQkJCQkJCQlcCiAJLyogZW52cCA9IGFyZ3YgKyBhcmdjICsgMSAqLwkJCQkJ XAogIglzaDJhZGQJJXIyNSwlcjI0LCVyMjNcbiIJCQkJCVwKICIJYmwJX2RsX2luaXQsJXIy XG4iCQkJCQkJXAo= --------------AALkclNdxA32MB4XPTMDm6jX--