From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by sourceware.org (Postfix) with ESMTPS id 4BBA53858C74 for ; Thu, 11 Aug 2022 16:42:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BBA53858C74 Received: by mail-ua1-x92d.google.com with SMTP id z14so7148486uaq.13 for ; Thu, 11 Aug 2022 09:42:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Up+4bKVzrRuPq/QJzqCH/e1CvrqpMWMzwJw7kGqiK+M=; b=kKq/exlABnoHfx+sYPPb25S9kKRBO6SLpWhKlF2HuuhHEwSdlelL5rOyOjGALWbS5/ geWKPhCzLQh7uoVelS2JqVsm8uaw5cfdAALTKYvYMBTLBnB1IfmrzBXnzvATzT+brGjG Dh5y1SNVoNzeSuGBJsJ1CqJWBf3M1wKpLbnn3axa8659YcztkQ+xqdWZ7h+jl2KtN2hr dQqub9/WVSBJG8dAHUCQg3LPC9VbuFCMwiyDZ+pItIek++CpurOw+DXw4y+SalbaLxsu c7V3m7GSKOq0vRRAY/x2/y0oKDfmkGZo+lE4aigBvpDGCQWMpvdSIXnzBkQi4Ldl3yjH zDXQ== X-Gm-Message-State: ACgBeo0a3QpU1f6U2WgMan7BznT5TA+fxELvbEohlJwb6J1Zg+Pu0k0N xpo6jC4/ZV09JVAutjeBmDH4fcawiyLdRA== X-Google-Smtp-Source: AA6agR7ixomRxfXX/6m0U7L+g/hnrkSDK3Z1pIxrS0CnVD/h0Ts4uLYxE7PYSRgkIFyypdFCs2GZqg== X-Received: by 2002:ab0:38d5:0:b0:387:5dfa:95e4 with SMTP id l21-20020ab038d5000000b003875dfa95e4mr12127uaw.50.1660236161413; Thu, 11 Aug 2022 09:42:41 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:89b:9d50:8d25:b9e5:dcfc? ([2804:1b3:a7c0:89b:9d50:8d25:b9e5:dcfc]) by smtp.gmail.com with ESMTPSA id r63-20020a1fa842000000b003778385dd05sm2218297vke.32.2022.08.11.09.42.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Aug 2022 09:42:40 -0700 (PDT) Message-ID: Date: Thu, 11 Aug 2022 13:42:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394) Content-Language: en-US To: libc-alpha@sourceware.org, Wilco Dijkstra References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 16:42:44 -0000 LGTM, thanks. On 11/08/22 13:25, Wilco Dijkstra via Libc-alpha wrote: > Fix a typo in the SVE configure check. This fixes BZ# 29394. > > --- > > diff --git a/sysdeps/aarch64/configure b/sysdeps/aarch64/configure > index bf972122b199e1dd7ef04c58dee99ed864274174..2130f6b8f8b423fbdc97b066e9cfe2cd977aa792 100644 > --- a/sysdeps/aarch64/configure > +++ b/sysdeps/aarch64/configure > @@ -303,7 +303,7 @@ aarch64-variant-pcs = $libc_cv_aarch64_variant_pcs" > # Check if asm support armv8.2-a+sve > { $as_echo "$as_me:${as_lineno-$LINENO}: checking for SVE support in assembler" >&5 > $as_echo_n "checking for SVE support in assembler... " >&6; } > -if ${libc_cv_asm_sve+:} false; then : > +if ${libc_cv_aarch64_sve_asm+:} false; then : > $as_echo_n "(cached) " >&6 > else > cat > conftest.s <<\EOF > @@ -321,8 +321,8 @@ else > fi > rm -f conftest* > fi > -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_asm_sve" >&5 > -$as_echo "$libc_cv_asm_sve" >&6; } > +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_aarch64_sve_asm" >&5 > +$as_echo "$libc_cv_aarch64_sve_asm" >&6; } > if test $libc_cv_aarch64_sve_asm = yes; then > $as_echo "#define HAVE_AARCH64_SVE_ASM 1" >>confdefs.h > > diff --git a/sysdeps/aarch64/configure.ac b/sysdeps/aarch64/configure.ac > index 51253d98025b6f5956575558e459d72e0763c674..85c6f765082811f5e8312eebda8d615eabcf39a1 100644 > --- a/sysdeps/aarch64/configure.ac > +++ b/sysdeps/aarch64/configure.ac > @@ -88,7 +88,7 @@ EOF > LIBC_CONFIG_VAR([aarch64-variant-pcs], [$libc_cv_aarch64_variant_pcs]) > > # Check if asm support armv8.2-a+sve > -AC_CACHE_CHECK(for SVE support in assembler, libc_cv_asm_sve, [dnl > +AC_CACHE_CHECK([for SVE support in assembler], [libc_cv_aarch64_sve_asm], [dnl > cat > conftest.s <<\EOF > ptrue p0.b > EOF >