From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 3E51A3858D20 for ; Fri, 14 Apr 2023 15:27:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E51A3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33EF3k3M020148; Fri, 14 Apr 2023 15:27:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=I4MXOo1ltgd6Re5iSZpoUsB3e7v26EBSP2f7+/t5beM=; b=KB1bJpwkEHRMl2skA3WVCs4qdkrOUS4uNw3Qn2ElCNOtnHn77X/XH3RY/k9ZQ9W2a+zc KqSFqASa/KxrqBU/Y/qvkXP5aJqnP62MsOFWQW/ntCJgFaPAoULlqQ67EeftjqZ9zTEy FQdh63wNayaaPPW0afSF4GlVX97/1q6FD2g+xjnXG2XpC2a7KvdFE3aGUESIebVQthp+ NdBLQWFxUbt25tfYYCYDm84Ccd1EPNJYSG+TrqV4OP5xHpJcrmPUaOI081/8G03X48zP fupoaegbWs+2PlnRTtvFxeuCnZqGkpVMImq5lxJpOYAlcSc7VYmaF/TfpEgSMw3PQJfy 6A== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3py94uh11h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 15:27:10 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33EDc8pd029810; Fri, 14 Apr 2023 15:27:09 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([9.208.130.98]) by ppma02dal.us.ibm.com (PPS) with ESMTPS id 3pu0fr1jcs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 15:27:09 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33EFR8Sw13566636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Apr 2023 15:27:08 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 611025805C; Fri, 14 Apr 2023 15:27:08 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35D0358062; Fri, 14 Apr 2023 15:27:08 +0000 (GMT) Received: from [9.163.11.173] (unknown [9.163.11.173]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 14 Apr 2023 15:27:08 +0000 (GMT) Message-ID: Date: Fri, 14 Apr 2023 10:27:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v5 07/22] powerpc: Fix Race conditions in pthread cancellation [BZ#12683] Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20230410195907.4123869-1-adhemerval.zanella@linaro.org> <20230410195907.4123869-8-adhemerval.zanella@linaro.org> From: Paul E Murphy In-Reply-To: <20230410195907.4123869-8-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FtAHImvD_7pG8NyucIlvw7OQdLBjntBw X-Proofpoint-ORIG-GUID: FtAHImvD_7pG8NyucIlvw7OQdLBjntBw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-14_08,2023-04-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 clxscore=1011 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304140132 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/10/23 2:58 PM, Adhemerval Zanella via Libc-alpha wrote: > By adding the required syscall_cancel.S. > > Checked on powerpc64le-linux-gnu, powerpc64-linux-gnu and > powerpc-linux-gnu. > --- Thanks. A couple trivial comments, but otherwise LGTM. Reviewed-by: Paul E. Murphy > +ENTRY (__syscall_cancel_arch) > + > + .globl __syscall_cancel_arch_start > +__syscall_cancel_arch_start: > + > + /* if (*cancelhandling & CANCELED_BITMASK) > + __syscall_do_cancel() */ > + lwz r0,0(r3) > + andi. r0,r0,TCB_CANCELED_BITMASK > + bne- 1f Really trivial opinion nit, the branch hint should be removed. > + > + /* Issue a 6 argument syscall, the nr [r4] being the syscall > + number. */ > + mr r0,r4 > + mr r3,r5 > + mr r4,r6 > + mr r5,r7 > + mr r6,r8 > + mr r7,r9 > + mr r8,r10 > + sc For consistency with the other syscall usage, can this also use the appropriate wrappers for using scv? > + > + .globl __syscall_cancel_arch_end > +__syscall_cancel_arch_end: > + > + bnslr+ > + neg r3,r3 > + blr > + > + /* Although the __syscall_do_cancel do not return, we need to stack > + being set correctly for unwind. */ > +1: > + TAIL_CALL_NO_RETURN (__syscall_do_cancel