From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 1C71E3857C5D for ; Thu, 19 Aug 2021 16:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C71E3857C5D Received: by mail-pl1-x634.google.com with SMTP id f3so4225103plg.3 for ; Thu, 19 Aug 2021 09:19:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=88tDtUtOfFMuCIiN3DvqQwzqDs9NzDKdqQits1RpQ60=; b=cldy6i5GE9qiUGX3CT86a3OG0k0ELANoxKaSiyX2fcpZ9/CjzEhySgCq0mMJH9Az2I LzX/9ld84iugYT5+gHikaoV4kWjxNaP7y0tunY+/HByPeVrmPVxZaD/Q8v/T7SVDzh2K 1Ry8BNMr9K/2gN0kaXH8xp9W6yiKWv8iodUEy9JtLNAZAFS3biEh7Tre5hAeZM11iN8R vDlGLKqne+8Dtnk8M7DZKpIiuOZHz4AZ0KkvIProYxhUAuLdO2i4OwYvcbC6SzXcpggR Ec+1zgoKNrOmXa2VlVtJhANkLDFleyG//eKPt+2ChWGWybNx5YggTs/F+6KsB9H+7ovw X5NQ== X-Gm-Message-State: AOAM531sybf4a1EY2NWK7y3rr0tLf2Wj+Ll7wQUbtM4YdU2Z8XH/Nvoo /Pr9xlEuNNny79f/Qd3GvaGisw== X-Google-Smtp-Source: ABdhPJzZ01CBA49B+3bhlXHfoaEcBNediGK9zf4hp9cnfeDw1e+LviJRxog+FVk1N276sYzJyZnezQ== X-Received: by 2002:a17:902:6bc7:b0:12d:aa67:695e with SMTP id m7-20020a1709026bc700b0012daa67695emr12396199plt.76.1629389968180; Thu, 19 Aug 2021 09:19:28 -0700 (PDT) Received: from ?IPv6:2804:431:c7ca:cd83:aa1a:7bd:9935:9bba? ([2804:431:c7ca:cd83:aa1a:7bd:9935:9bba]) by smtp.gmail.com with ESMTPSA id v25sm3849135pfm.202.2021.08.19.09.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Aug 2021 09:19:27 -0700 (PDT) Subject: Re: [PATCH v3 0/7] Fix getdents{64} regression on some FS To: John Paul Adrian Glaubitz , libc-alpha@sourceware.org, Florian Weimer Cc: Dave Flogeras , James Clarke References: <20201021141542.2003377-1-adhemerval.zanella@linaro.org> <96ad574e-79d3-fc5d-e45d-2bd0fa89c46b@physik.fu-berlin.de> From: Adhemerval Zanella Message-ID: Date: Thu, 19 Aug 2021 13:19:25 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <96ad574e-79d3-fc5d-e45d-2bd0fa89c46b@physik.fu-berlin.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 16:19:39 -0000 On 19/08/2021 13:07, John Paul Adrian Glaubitz wrote: > Hello! > > On 10/21/20 4:15 PM, Adhemerval Zanella wrote: >> This is updated version [1], rebased against master add with some >> suggestion from previous review. The main changes are: >> >> - The translation buffer is allocated as an auxiliarry one (instead >> of a reserved spacefrom the dirstream) and readdir might reallocate >> it if it finds a large entry. >> >> - Failures in non-LFS readdir (such as d_ino/d_off overflow or failure >> in expand the translation buffer) is ignored. This allows code that >> does not handle possible failure in readdir to successful read the >> rest of entries in the directory. >> >> - So minor fixes in dirent/tst-seekdir2.c >> >> - Added __attribute_deprecated_msg__ on getdirentries to redirect to >> getdents64. >> >> I have checked on x86_64-linux-gnu, powerpc64-linux-gnu and on some >> 32-bit ABIs arm-linux-gnueabihf, powerpc-linux-gnu, and sparcv9-linux-gnu. > > Are there any news on this patch series besides the v3 version? [1] Unfortunately it is requires reviews. Since it only affects legacy ABIs there is no much traction for fixing it. > > Thanks, > Adrian > >> [1] https://patchwork.ozlabs.org/project/glibc/list/?series=209257 >