From: "Maciej W. Rozycki" <macro@mips.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: <libc-alpha@sourceware.org>, Florian Weimer <fweimer@redhat.com>,
Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH v2 2/2] libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307]
Date: Thu, 05 Jul 2018 17:10:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1807051745560.22261@tp.orcam.me.uk> (raw)
In-Reply-To: <56d6a870-7caa-5f55-81fd-4565525a36ed@redhat.com>
Hi Carlos,
> > +* The GNU C Library now has correct support for ABSOLUTE symbols
> > + (SHN_ABS-relative symbols). Previously such ABSOLUTE symbols were
> > + relocated incorrectly or in some cases discarded. The GNU linker can
> > + make use of this newer semantics, but it must communicate it to the
>
> Suggest:
> "make use of the corrected semantics, ..."
Hmm, "semantics" is uncountable rather than plural[1], so I'm not sure if
"this semantics" is actually a grammatical mistake (just like "Can I drink
this milk?" is fine), but I'm fine with your suggestion. I actually
considered using "the" to avoid having this discussion. ;)
Committed with your suggestion applied then. Thank you for your review.
Maciej
References:
[1] <https://www.oxfordlearnersdictionaries.com/definition/american_english/semantics>
next prev parent reply other threads:[~2018-07-05 17:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 18:06 [PATCH 0/2] Accept absolute symbols whose value is zero [BZ #23307] Maciej W. Rozycki
2018-06-18 18:08 ` [PATCH 1/2] elf: Accept absolute (SHN_ABS) " Maciej W. Rozycki
2018-06-25 20:25 ` Florian Weimer
2018-06-29 16:13 ` [committed v2 " Maciej W. Rozycki
2018-06-29 17:41 ` Joseph Myers
2018-06-29 18:05 ` Maciej W. Rozycki
2018-06-18 18:08 ` [PATCH 2/2] libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307] Maciej W. Rozycki
2018-06-25 20:33 ` Florian Weimer
2018-06-27 22:08 ` Maciej W. Rozycki
2018-06-28 6:59 ` Florian Weimer
2018-06-28 13:49 ` Maciej W. Rozycki
2018-06-28 13:54 ` Florian Weimer
2018-06-28 14:54 ` Maciej W. Rozycki
2018-06-29 16:29 ` Maciej W. Rozycki
2018-07-03 13:53 ` Carlos O'Donell
2018-07-05 15:42 ` [PATCH v2 " Maciej W. Rozycki
2018-07-05 16:29 ` Carlos O'Donell
2018-07-05 17:10 ` Maciej W. Rozycki [this message]
2018-07-05 18:02 ` Carlos O'Donell
2018-06-25 19:14 ` [PING][PATCH 0/2] Accept absolute symbols whose value is zero [BZ #23307] Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1807051745560.22261@tp.orcam.me.uk \
--to=macro@mips.com \
--cc=amodra@gmail.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).