* mempcpy change breaks the sparc build
@ 2014-11-14 1:40 David Miller
2014-11-14 1:47 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-11-14 1:40 UTC (permalink / raw)
To: joseph; +Cc: libc-alpha
"Fix stpcpy / mempcpy namespace (bug 17573)." causes the following
build failure on sparc:
../string/mempcpy.c:37:1: error: ‘mempcpy’ aliased to undefined symbol ‘__mempcpy’
Sparc does:
sysdeps/sparc/sparc64/rtld-memcpy.c:#include <string/mempcpy.c>
to avoid the multiarch mempcpy implementation being used in ld.so
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mempcpy change breaks the sparc build
2014-11-14 1:40 mempcpy change breaks the sparc build David Miller
@ 2014-11-14 1:47 ` David Miller
2014-11-14 1:58 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-11-14 1:47 UTC (permalink / raw)
To: joseph; +Cc: libc-alpha
From: David Miller <davem@davemloft.net>
Date: Thu, 13 Nov 2014 20:40:52 -0500 (EST)
>
> "Fix stpcpy / mempcpy namespace (bug 17573)." causes the following
> build failure on sparc:
>
> ../string/mempcpy.c:37:1: error: ‘mempcpy’ aliased to undefined symbol ‘__mempcpy’
>
> Sparc does:
>
> sysdeps/sparc/sparc64/rtld-memcpy.c:#include <string/mempcpy.c>
>
> to avoid the multiarch mempcpy implementation being used in ld.so
I just noticed:
https://sourceware.org/ml/libc-alpha/2014-11/msg00305.html
and am testing it now.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mempcpy change breaks the sparc build
2014-11-14 1:47 ` David Miller
@ 2014-11-14 1:58 ` David Miller
2014-11-14 13:49 ` Joseph Myers
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2014-11-14 1:58 UTC (permalink / raw)
To: joseph; +Cc: libc-alpha
From: David Miller <davem@davemloft.net>
Date: Thu, 13 Nov 2014 20:47:08 -0500 (EST)
> I just noticed:
>
> https://sourceware.org/ml/libc-alpha/2014-11/msg00305.html
>
> and am testing it now.
Joseph, I had to add the following to your patch in order to make
sparc work:
diff --git a/sysdeps/sparc/sparc64/rtld-memcpy.c b/sysdeps/sparc/sparc64/rtld-memcpy.c
index b1b0647..52f8302 100644
--- a/sysdeps/sparc/sparc64/rtld-memcpy.c
+++ b/sysdeps/sparc/sparc64/rtld-memcpy.c
@@ -1,2 +1,3 @@
+#define NO_MEMPCPY_STPCPY_REDIRECT
#include <string/memcpy.c>
#include <string/mempcpy.c>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mempcpy change breaks the sparc build
2014-11-14 1:58 ` David Miller
@ 2014-11-14 13:49 ` Joseph Myers
2014-11-14 18:33 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Joseph Myers @ 2014-11-14 13:49 UTC (permalink / raw)
To: David Miller; +Cc: libc-alpha
On Fri, 14 Nov 2014, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 13 Nov 2014 20:47:08 -0500 (EST)
>
> > I just noticed:
> >
> > https://sourceware.org/ml/libc-alpha/2014-11/msg00305.html
> >
> > and am testing it now.
>
> Joseph, I had to add the following to your patch in order to make
> sparc work:
I have now committed my patch, please commit yours.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mempcpy change breaks the sparc build
2014-11-14 13:49 ` Joseph Myers
@ 2014-11-14 18:33 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2014-11-14 18:33 UTC (permalink / raw)
To: joseph; +Cc: libc-alpha
From: Joseph Myers <joseph@codesourcery.com>
Date: Fri, 14 Nov 2014 13:49:21 +0000
> On Fri, 14 Nov 2014, David Miller wrote:
>
>> From: David Miller <davem@davemloft.net>
>> Date: Thu, 13 Nov 2014 20:47:08 -0500 (EST)
>>
>> > I just noticed:
>> >
>> > https://sourceware.org/ml/libc-alpha/2014-11/msg00305.html
>> >
>> > and am testing it now.
>>
>> Joseph, I had to add the following to your patch in order to make
>> sparc work:
>
> I have now committed my patch, please commit yours.
Done, thanks Joseph.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-14 18:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-14 1:40 mempcpy change breaks the sparc build David Miller
2014-11-14 1:47 ` David Miller
2014-11-14 1:58 ` David Miller
2014-11-14 13:49 ` Joseph Myers
2014-11-14 18:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).