public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Fix elf/tst-unique4lib.cc warning
@ 2014-11-26 13:32 Joseph Myers
  2014-12-02 17:48 ` Ping " Joseph Myers
  2014-12-02 20:43 ` Roland McGrath
  0 siblings, 2 replies; 3+ messages in thread
From: Joseph Myers @ 2014-11-26 13:32 UTC (permalink / raw)
  To: libc-alpha

This patch fixes a warning "tst-unique4lib.cc:17:12: warning: 'b'
defined but not used [-Wunused-variable]".  I'm not sure exactly what
aspects of the test are or are not significant for the issue it is
testing for; the patch makes the minimal change of marking the
variable with __attribute__ ((used)).

Tested for x86_64.

2014-11-26  Joseph Myers  <joseph@codesourcery.com>

	* elf/tst-unique4lib.cc (b): Mark with __attribute__ ((used)).

diff --git a/elf/tst-unique4lib.cc b/elf/tst-unique4lib.cc
index c9fdf9c..20a10e9 100644
--- a/elf/tst-unique4lib.cc
+++ b/elf/tst-unique4lib.cc
@@ -14,4 +14,4 @@ static int a[24] =
     S<23>::i, S<24>::i
   };
 
-static int b = S<1>::j;
+static int b __attribute__ ((used)) = S<1>::j;

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Ping Re: Fix elf/tst-unique4lib.cc warning
  2014-11-26 13:32 Fix elf/tst-unique4lib.cc warning Joseph Myers
@ 2014-12-02 17:48 ` Joseph Myers
  2014-12-02 20:43 ` Roland McGrath
  1 sibling, 0 replies; 3+ messages in thread
From: Joseph Myers @ 2014-12-02 17:48 UTC (permalink / raw)
  To: libc-alpha

Ping.  This patch 
<https://sourceware.org/ml/libc-alpha/2014-11/msg00768.html> is pending 
review.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix elf/tst-unique4lib.cc warning
  2014-11-26 13:32 Fix elf/tst-unique4lib.cc warning Joseph Myers
  2014-12-02 17:48 ` Ping " Joseph Myers
@ 2014-12-02 20:43 ` Roland McGrath
  1 sibling, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2014-12-02 20:43 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha

OK

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-02 20:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-26 13:32 Fix elf/tst-unique4lib.cc warning Joseph Myers
2014-12-02 17:48 ` Ping " Joseph Myers
2014-12-02 20:43 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).