From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37557 invoked by alias); 1 Mar 2015 22:24:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 37548 invoked by uid 89); 1 Mar 2015 22:24:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Sun, 01 Mar 2015 22:24:00 -0000 From: Joseph Myers To: John David Anglin CC: Mike Frysinger , , Subject: Re: [PATCH] hppa: fix __O_SYNC to match the kernel In-Reply-To: Message-ID: References: <1424755185-27627-1-git-send-email-vapier@gentoo.org> <20150227065339.GO29461@vapier> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2015-03/txt/msg00014.txt.bz2 On Sun, 1 Mar 2015, John David Anglin wrote: > The main bug in feholdexcept is the second set of bufptr. This existed > to the restore the exception registers in reverse order. This statement > should have been removed when the code was changed to only update the > status and first exception registers. The offset used in the statement > is also off by a factor two, so it probably never worked correctly. > With the current patch, the code loads zero to the status and exception > register. As a result, the T bit is not set properly. If this bug was user-visible in a release, there should be a bug filed in Bugzilla for it (this generally applies when fixing any bug that was user-visible in a release). -- Joseph S. Myers joseph@codesourcery.com