From: Joseph Myers <joseph@codesourcery.com>
To: Wilco Dijkstra <wdijkstr@arm.com>
Cc: "'Ondřej Bílka'" <neleai@seznam.cz>, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/*] Optimize generic strchrnul and strchr
Date: Thu, 28 May 2015 18:05:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1505281733001.16930@digraph.polyomino.org.uk> (raw)
In-Reply-To: <000d01d09879$ae9c2d80$0bd48880$@com>
On Wed, 27 May 2015, Wilco Dijkstra wrote:
> Finally first_nonzero_byte should just use __builtin_ffsl (yet another
> function that should be inlined by default in the generic string.h...).
Will GCC always inline __builtin_ffsl (or call a libgcc function) rather
than generating a call to ffsl (user namespace) on some architectures? If
it can ever call ffsl you need to do something similar to how we handle
__mempcpy calling __builtin_mempcpy (include/string.h redeclares mempcpy
with __asm__ ("__mempcpy"), so that libc-internal calls to __mempcpy
really do call that function at the assembler level if not inlined, rather
than calling mempcpy and having namespace issues).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2015-05-28 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 14:10 Wilco Dijkstra
2015-05-27 20:33 ` Ondřej Bílka
2015-05-28 11:27 ` Chris Metcalf
2015-05-28 18:05 ` Joseph Myers [this message]
2015-05-28 19:41 ` Ondřej Bílka
2015-05-28 20:36 ` Joseph Myers
-- strict thread matches above, loose matches on Subject: below --
2015-05-27 9:19 [PATCH 1/*] Generic string function optimization: Add skeleton Ondřej Bílka
2015-05-27 9:19 ` [PATCH 2/*] Optimize generic strchrnul and strchr Ondřej Bílka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1505281733001.16930@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=neleai@seznam.cz \
--cc=wdijkstr@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).