From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11392 invoked by alias); 8 Jun 2015 10:37:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 10816 invoked by uid 89); 8 Jun 2015 10:37:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Mon, 08 Jun 2015 11:24:00 -0000 From: Joseph Myers To: =?ISO-8859-2?Q?Ond=F8ej_B=EDlka?= CC: Subject: Re: [PATCH 2/*] Remove pre-gcc 3.4 string inline optimizations. In-Reply-To: <20150608093428.GA19347@domone> Message-ID: References: <20150524150715.GA31589@domone> <20150524152706.GB31589@domone> <20150608093428.GA19347@domone> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-604821967-1433759851=:25225" X-SW-Source: 2015-06/txt/msg00262.txt.bz2 ---1152306461-604821967-1433759851=:25225 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-length: 901 On Mon, 8 Jun 2015, Ondřej Bílka wrote: > On Thu, May 28, 2015 at 04:05:56PM +0000, Joseph Myers wrote: > > On Sun, 24 May 2015, Ondřej Bílka wrote: > > > > > -/* GCC < 3.0 optimizes memset(s, 0, n) but not bzero(s, n). > > > - The optimization is broken before EGCS 1.1. > > > - GCC 3.0+ has __builtin_bzero as well, but at least till GCC 3.4 > > > - if it decides to call the library function, it calls memset > > > - and not bzero. */ > > > -# if __GNUC_PREREQ (2, 91) > > > -# define __bzero(s, n) __builtin_memset (s, '\0', n) > > > -# endif > > > > It looks like you're removing a definition that would be used with current > > GCC here. > > > As comment says its unnecessary as gcc 4 converts bzero to memset as > this header tries. This macro definition is of __bzero, not bzero. GCC does not do anything special with __bzero. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-604821967-1433759851=:25225--