From: Joseph Myers <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: "GNU C. Library" <libc-alpha@sourceware.org>
Subject: Re: [PATCH roland/arm] Conditionalize test-xfail-tst-tlsalign{,-static} on ARM assembler bug.
Date: Sat, 27 Jun 2015 20:49:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1506262058270.28580@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20150626163206.675CC2C3B3B@topped-with-meat.com>
On Fri, 26 Jun 2015, Roland McGrath wrote:
> diff --git a/sysdeps/arm/configure.ac b/sysdeps/arm/configure.ac
> index 168f2e7..d7b6a7a 100644
> --- a/sysdeps/arm/configure.ac
> +++ b/sysdeps/arm/configure.ac
> @@ -79,6 +79,43 @@ if test $libc_cv_arm_pcrel_movw = yes; then
> AC_DEFINE([ARM_PCREL_MOVW_OK])
> fi
>
> +AC_CACHE_CHECK([whether TPOFF relocs with addends are assembled correctly],
> + libc_cv_arm_tpoff_addend, [
This should have a comment referencing the binutils bug and the versions
in which it is fixed. OK with such a comment added. (I think the glibc
bug should be closed as fixed and listed as fixed in NEWS since the only
remaining cases are a problem in binutils not glibc.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2015-06-26 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 20:29 Roland McGrath
2015-06-27 20:49 ` Joseph Myers [this message]
2015-07-08 22:03 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1506262058270.28580@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).