From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46329 invoked by alias); 29 Mar 2016 21:32:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 44794 invoked by uid 89); 29 Mar 2016 21:32:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=doubtful, 2612 X-HELO: relay1.mentorg.com Date: Tue, 29 Mar 2016 21:32:00 -0000 From: Joseph Myers To: Adhemerval Zanella CC: Subject: Re: [PATCH 1/3] Adjust kernel-features.h defaults for recvmsg and sendmsg In-Reply-To: <1459175641-12520-2-git-send-email-adhemerval.zanella@linaro.org> Message-ID: References: <1459175641-12520-1-git-send-email-adhemerval.zanella@linaro.org> <1459175641-12520-2-git-send-email-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-03/txt/msg00708.txt.bz2 On Mon, 28 Mar 2016, Adhemerval Zanella wrote: > +/* Support for recvmsg and sendmsg was added in 2.6.12 in most architectures, > + with some added later (for instance 2.6.37 for powerpc) and for some only > + through syscall (with wire-up syscall added in later versionsi). Define > + __ASSUME_RECVMSG_SYSCALL and __ASUME_SENDMSG_SYSCALL if glibc uses direct > + syscall, otherwise glibc will use socketcall. */ This comment is a mess. * I'm doubtful of the "added in 2.6.12". Do you actually mean not in 2.6.11 as verified by comparing 2.6.11 and 2.6.12, or do you mean that 2.6.12 is the first release *in git* with the syscalls (for the trivial reason that it was the first release in git at all)? * "only through syscall" looks wrong in that context; I think you mean "only through socketcall". * "versionsi" typo. * "__ASUME_SENDMSG_SYSCALL" typo. I think you mean something more like: /* On most architectures, most socket syscalls are supported for all supported kernel versions, but on some socketcall architectures separate syscalls were only added later. */ which does not need to go into details of the particular versions for particular architectures. -- Joseph S. Myers joseph@codesourcery.com