From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-69684-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 42249 invoked by alias); 18 May 2016 21:19:56 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 42240 invoked by uid 89); 18 May 2016 21:19:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: relay1.mentorg.com
Date: Wed, 18 May 2016 21:24:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 4/8] Add LIT() around literals in check_ulp in
 libm-tests.inc
In-Reply-To: <be245395cdf20cd5c966d04902a46740bf3e681f.1463599718.git.murphyp@linux.vnet.ibm.com>
Message-ID: <alpine.DEB.2.20.1605182118170.7137@digraph.polyomino.org.uk>
References: <cover.1463599718.git.murphyp@linux.vnet.ibm.com> <be245395cdf20cd5c966d04902a46740bf3e681f.1463599718.git.murphyp@linux.vnet.ibm.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-SW-Source: 2016-05/txt/msg00400.txt.bz2

On Wed, 18 May 2016, Paul E. Murphy wrote:

> -   ulps = ulp (0x0.0p0);
> +   ulps = ulp (LIT (0x0.0p0));

But ulp is a function and implicitly converts its argument.  You don't 
need the suffixes.  Just passing an integer 0 or 1 in these cases and 
relying on implicit conversions seems best, to make the code less 
macro-heavy.

-- 
Joseph S. Myers
joseph@codesourcery.com