From: Joseph Myers <joseph@codesourcery.com>
To: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCHv3 3/4] ldbl-128: Mechanical L(x) cleanup.
Date: Fri, 26 Aug 2016 22:18:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1608262201190.1996@digraph.polyomino.org.uk> (raw)
In-Reply-To: <e6c6d27d29c6523063120ec18162ab37c0c2aaae.1471902174.git.murphyp@linux.vnet.ibm.com>
I don't see the point of these cleanups in patches 3 or 4. Adding spaces
inside L() to line up decimal points in tables of figures that are
inherently not human-readable doesn't seem like an improvement; the
important thing to be readable is the comments explaining semantics of the
tables of figures. Adding L() mechanically has not made the formatting
any worse.
That said: some of the changes are to tables that clearly aren't formatted
according to the GNU Coding Standards (for example, have no indentation at
all). In such cases, fixing to follow the GNU Coding Standards (which
typically means two-column indentation - again, no spaces inside L(), and
nothing to line up decimal points of positive and negative values) is
perfectly OK, it just has nothing to do with float128 support.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-08-26 22:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 16:28 [PATCHv3 0/4] Enable sharing of ldbl-128 with float128 Paul E. Murphy
2016-08-24 16:29 ` [PATCHv3 4/4] ldbl-128: Manually cleanup whitespace issues from L(x) application Paul E. Murphy
2016-08-24 16:29 ` [PATCHv3 1/4] ldbl-128: Rename 'long double' to '_Float128' Paul E. Murphy
2016-08-26 21:55 ` Joseph Myers
2016-08-30 15:31 ` Paul E. Murphy
2016-08-30 17:16 ` Joseph Myers
2016-08-31 15:40 ` Paul E. Murphy
2016-08-31 17:03 ` Joseph Myers
2016-08-31 18:27 ` Paul E. Murphy
2016-08-31 20:37 ` Joseph Myers
2016-08-31 22:29 ` Paul E. Murphy
2016-08-30 17:42 ` Joseph Myers
2016-08-24 16:30 ` [PATCHv3 3/4] ldbl-128: Mechanical L(x) cleanup Paul E. Murphy
2016-08-26 22:18 ` Joseph Myers [this message]
2016-08-29 13:44 ` Paul E. Murphy
2016-08-24 16:30 ` [PATCHv3 2/4] ldbl-128: Use L(x) macro for long double constants Paul E. Murphy
2016-09-02 15:10 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608262201190.1996@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=murphyp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).