From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6495 invoked by alias); 30 Aug 2016 17:10:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 6479 invoked by uid 89); 30 Aug 2016 17:10:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Tue, 30 Aug 2016 17:10:00 -0000 From: Joseph Myers To: Zack Weinberg CC: Subject: Re: [PATCH 08/13] Installed-header hygiene (BZ#20366): time.h types. In-Reply-To: <20160830011645.25769-9-zackw@panix.com> Message-ID: References: <20160830011645.25769-1-zackw@panix.com> <20160830011645.25769-2-zackw@panix.com> <20160830011645.25769-3-zackw@panix.com> <20160830011645.25769-4-zackw@panix.com> <20160830011645.25769-5-zackw@panix.com> <20160830011645.25769-6-zackw@panix.com> <20160830011645.25769-7-zackw@panix.com> <20160830011645.25769-8-zackw@panix.com> <20160830011645.25769-9-zackw@panix.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-08/txt/msg00905.txt.bz2 On Mon, 29 Aug 2016, Zack Weinberg wrote: > Rather than make the logic in time.h even messier, I had been kicking > around in my head the idea of replacing the __need/__defined mechanism > with a set of small headers, bits/types/foo_t.h for every foo_t that > more than one header may need to define. This seemed like a good > place to give it a try. I rather like the effect; time.h and > bits/time.h are now *much* simpler, and a lot of other headers are > slightly simpler. Without having reviewed the details of this patch, I support the principle of replacing __need_* like this, having advocated it in . -- Joseph S. Myers joseph@codesourcery.com