From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83939 invoked by alias); 31 Aug 2016 16:47:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 83927 invoked by uid 89); 31 Aug 2016 16:47:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=sk:M_LIBM_, sk:LONG_DO, LDOUBLE_, fdim X-HELO: relay1.mentorg.com Date: Wed, 31 Aug 2016 16:47:00 -0000 From: Joseph Myers To: "Paul E. Murphy" CC: Subject: Re: [PATCH 1/5] Make common fdim implementation generic. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-08/txt/msg00928.txt.bz2 On Tue, 30 Aug 2016, Paul E. Murphy wrote: > /* Define compat symbols for long double on platforms > where it was not always a distinct type. */ > -#define M_LIBM_NEED_COMPAT(f) \ > - LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version) > +#if !defined M_LIBM_NEED_COMPAT > +# define M_LIBM_NEED_COMPAT(f) \ > + LONG_DOUBLE_COMPAT (libm, LDOUBLE_ ## f ## l_libm_version) Two-column indentation is still correct for the continuation line; it should not be changed. > -#define declare_mgen_libm_compat(from, to) \ > - compat_symbol (libm, from, to ## l, \ > +#if !defined declare_mgen_libm_compat > +# define declare_mgen_libm_compat(from, to) \ > + compat_symbol (libm, from, to ## l, \ > LDOUBLE_ ## to ## l_libm_version); Likewise here (if a change were correct, the following line would have needed reindenting as well to stay aligned with the '('). > -#define declare_mgen_alias(from, to) \ > - long_double_symbol (libm, from ## l, to ## l); > +#if !defined declare_mgen_alias > +# define declare_mgen_alias(from, to) \ > + long_double_symbol (libm, from ## l, to ## l); Likewise here. OK with those fixes. -- Joseph S. Myers joseph@codesourcery.com