From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 3/3] Consolidate posix_fadvise implementations
Date: Wed, 12 Oct 2016 15:39:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610121527340.10909@digraph.polyomino.org.uk> (raw)
In-Reply-To: <086eefb0-907f-7dea-0af6-b3f4b15eddc7@linaro.org>
On Wed, 12 Oct 2016, Adhemerval Zanella wrote:
> For some reason I am not seeing this issue with my mips64n64 toolchain
> (gcc 5.3.1, binutils 2.26.0.20160331).
I was using GCC 5.4.1 20160810 and binutils 2.27.51.20160810. I've now
updated to today's GCC 5 branch and binutils master, and still see the
same issue, in a clean build from scratch.
The error is complaining about libc.so when linking sotruss-lib.so.
libc.so has (readelf --dyn-syms)
262: 000000000010b950 28 FUNC GLOBAL DEFAULT 12 posix_fadvise64@GLIBC_2.2
417: 000000000010b950 28 FUNC WEAK DEFAULT 12 posix_fadvise64@@GLIBC_2.2
1505: 000000000010b950 28 FUNC GLOBAL DEFAULT 12 posix_fadvise64@@GLIBC_2.3.3
that is, two separate definitions at version GLIBC_2.2. It looks to me
like sysdeps/unix/sysv/linux/posix_fadvise64.c would create a
posix_fadvise64 weak_alias, while
sysdeps/unix/sysv/linux/mips/mips64/n64/posix_fadvise64.c then adds
compat_symbol / versioned_symbol calls. If a symbol is being created with
explicit versioning, direct weak_alias / strong_alias calls for it should
be disabled.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-10-12 15:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 0:15 [PATCH v2 1/3] Consolidate fallocate{64} implementations Adhemerval Zanella
2016-09-28 0:15 ` [PATCH v2 2/3] Consolidate posix_fallocate{64} implementations Adhemerval Zanella
2016-10-05 17:02 ` Siddhesh Poyarekar
2016-10-05 17:51 ` Adhemerval Zanella
2016-10-05 18:19 ` Siddhesh Poyarekar
2016-09-28 0:15 ` [PATCH v2 3/3] Consolidate posix_fadvise implementations Adhemerval Zanella
2016-10-05 17:15 ` Siddhesh Poyarekar
2016-10-06 20:50 ` Adhemerval Zanella
2016-10-11 23:47 ` Joseph Myers
2016-10-12 13:51 ` Adhemerval Zanella
2016-10-12 15:39 ` Joseph Myers [this message]
2016-10-12 16:05 ` Adhemerval Zanella
2016-10-12 16:11 ` Joseph Myers
2016-10-12 16:14 ` Adhemerval Zanella
2016-09-30 0:51 ` [PATCH v2 1/3] Consolidate fallocate{64} implementations Siddhesh Poyarekar
2016-10-04 15:07 ` Adhemerval Zanella
2016-10-05 6:54 ` Siddhesh Poyarekar
2016-10-05 14:49 ` Adhemerval Zanella
2016-10-05 16:50 ` Siddhesh Poyarekar
2016-10-17 14:15 ` Andreas Schwab
2016-10-17 14:20 ` Andreas Schwab
2016-10-17 15:52 ` Andreas Schwab
2016-10-17 15:57 ` Christoph Hellwig
2016-10-17 18:59 ` Adhemerval Zanella
2016-10-18 9:55 ` Florian Weimer
2016-10-18 7:45 ` Andreas Schwab
2016-10-17 14:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610121527340.10909@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).