From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85422 invoked by alias); 14 Oct 2016 21:40:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 85404 invoked by uid 89); 14 Oct 2016 21:40:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=suffix, gomes, tst-strtod.h, sk:tststr X-HELO: relay1.mentorg.com Date: Fri, 14 Oct 2016 21:40:00 -0000 From: Joseph Myers To: "Gabriel F. T. Gomes" CC: Subject: Re: [PATCH v8 3/3] Add tests for strfrom functions In-Reply-To: <1476466285-17655-4-git-send-email-gftg@linux.vnet.ibm.com> Message-ID: References: <1476466285-17655-1-git-send-email-gftg@linux.vnet.ibm.com> <1476466285-17655-4-git-send-email-gftg@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-10/txt/msg00244.txt.bz2 On Fri, 14 Oct 2016, Gabriel F. T. Gomes wrote: > + double val; Some of the test arrays are still using double rather than using the type under test in a type-generic way (thus, either having multiple arrays or having a struct member per type as in the tst-strtod-round tests). > +struct val > +{ > + float f; > + double d; > + long double ld; > +}; Although this one has a struct with multiple types, it's not properly type-generic. I'd expect use of something like STRUCT_FOREACH_FLOAT_FTYPE (in tst-strtod-round-skeleton.c) to define such a struct, and then such a macro concatenting a suffix to the constants to fill in the initializers. If the tests are properly type-generic, only GEN_TEST_STRTOD_FOREACH / STRTOD_TEST_FOREACH in tst-strtod.h should likely need to change to make them cover an extra type. -- Joseph S. Myers joseph@codesourcery.com