From: Joseph Myers <joseph@codesourcery.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Define iszero as a function template for C++ [BZ #20715]
Date: Fri, 21 Oct 2016 16:13:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610211610310.27636@digraph.polyomino.org.uk> (raw)
In-Reply-To: <2b2fa3c4-5bd6-4025-717f-fe2e2ee19555@redhat.com>
On Fri, 21 Oct 2016, Florian Weimer wrote:
> Tested on x86_64, ppc64, ppc64le, s390x, aarch64.
>
> I'm not sure if the new test is particularly meaningful, but at least it
> catches syntax errors in <math.h>.
This seems fine to me (with negative zero included in the testcase), and
in accordance with how C++ defines bindings for C99 macros such as
infinite. I presume you're deliberately leaving it to future libstdc++
versions to handle the other is* macros from TS 18661-1 if they get into
C2x and then into C++, as you haven't observed them causing problems for
C++ code at present.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-10-21 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 13:42 Florian Weimer
2016-10-21 16:13 ` Joseph Myers [this message]
2016-10-21 16:16 ` Florian Weimer
2016-10-21 16:24 ` Joseph Myers
2016-10-21 16:31 ` Florian Weimer
2016-10-22 15:35 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610211610310.27636@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).