From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68130 invoked by alias); 26 Oct 2016 20:12:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 68115 invoked by uid 89); 26 Oct 2016 20:12:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:734, fortune, Fortune X-HELO: relay1.mentorg.com Date: Wed, 26 Oct 2016 20:12:00 -0000 From: Joseph Myers To: Matthew Fortune CC: "libc-alpha@sourceware.org" , "Sandra Loosemore (sandra@codesourcery.com)" , Petar Jovanovic Subject: Re: [PATCH] Initialise the machine specific part of rtld bootstrap map In-Reply-To: <6D39441BF12EF246A7ABCE6654B0235380AABFF9@HHMAIL01.hh.imgtec.org> Message-ID: References: <6D39441BF12EF246A7ABCE6654B0235380AABFF9@HHMAIL01.hh.imgtec.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-10/txt/msg00478.txt.bz2 On Wed, 26 Oct 2016, Matthew Fortune wrote: > +# ifdef ELF_MACHINE_INIT_MAP > + ELF_MACHINE_INIT_MAP (bootstrap_map); > +# endif We don't encourage use of #ifdef like that. It's better to have an inline function defined everywhere and used unconditionally, for which most systems have a dummy definition (see dl-machine-reject-phdr.h and elf_machine_reject_phdr_p for an example - if you have a header for a single function, you don't need to update lots of dl-machine.h headers, just add a generic version - which has the comments detailing the semantics of the function and when it's needed - and a MIPS version). -- Joseph S. Myers joseph@codesourcery.com