From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19609 invoked by alias); 28 Oct 2016 12:49:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 19587 invoked by uid 89); 28 Oct 2016 12:49:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 28 Oct 2016 12:49:00 -0000 From: Joseph Myers To: Florian Weimer CC: Carlos O'Donell , GNU C Library Subject: Re: [PATCH] Fix -Os related -Werror failures. In-Reply-To: <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> Message-ID: References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-10/txt/msg00520.txt.bz2 On Fri, 28 Oct 2016, Florian Weimer wrote: > Those who want to build with -Os or other special compiler flags should just > configure with --disable-werror. We can't account for every optimization > someone might want to disable in their build. I don't think --disable-werror should be encouraged. We could add DIAG_* macro variants that do nothing except with -Os so don't disable the warnings in other cases, if there isn't a code cleanup to avoid the warnings. -- Joseph S. Myers joseph@codesourcery.com