From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92206 invoked by alias); 28 Oct 2016 14:17:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 92180 invoked by uid 89); 28 Oct 2016 14:17:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 28 Oct 2016 14:17:00 -0000 From: Joseph Myers To: Carlos O'Donell CC: Florian Weimer , GNU C Library Subject: Re: [PATCH v2] Fix -Os related build and test failures. In-Reply-To: <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> Message-ID: References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com> <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com> <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-10/txt/msg00540.txt.bz2 On Fri, 28 Oct 2016, Carlos O'Donell wrote: > - Fix math/test-nan-overflow.c which uses malloc but doesn't include > stdlib.h. I don't know what's including but not for -Os, but this fix should be separate (and committed as obvious). > - Define DIAG_IGNORE_Ox_NEEDS_COMMENT and DIAG_IGNORE_Os_NEEDS_COMMENT > for use with diagnostics which should be ignored only when optimizing, > or when optimizing for size. If we need *Ox* to be finer grained, then > we'll have to setup something more complicated, but for now we don't > need it. I don't think we need the -Ox version. glibc is always built with optimization, and if we fix things (for better debugging) so that only a few bits need to be built with optimization and the rest is correct without, it's harmess for the pragmas to be in effect with -O0 even if not needed in that case. -- Joseph S. Myers joseph@codesourcery.com