From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130312 invoked by alias); 28 Oct 2016 17:09:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 130302 invoked by uid 89); 28 Oct 2016 17:09:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 28 Oct 2016 17:09:00 -0000 From: Joseph Myers To: Adhemerval Zanella CC: Subject: Re: [PATCH] crypt: Use internal names for the SHA-2 block functions In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-10/txt/msg00551.txt.bz2 On Fri, 28 Oct 2016, Adhemerval Zanella wrote: > It should __sha256_process_block_generic here. Also, if we now aiming > for namespace clean shouldn't we also add a conform test for crypt.h > header? crypt.h is not in any standard supported by the conform tests. It's true that linknamespace considerations apply even for _DEFAULT_SOURCE and _GNU_SOURCE - using a function declared under one of those conditions should not bring in a reference to a function not so declared. The difficulty in testing this is that it really needs a list of all installed headers to be visible in one place (and there's the question of whether we consider _DEFAULT_SOURCE to include all headers or not). -- Joseph S. Myers joseph@codesourcery.com