From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28139 invoked by alias); 28 Oct 2016 17:48:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 20624 invoked by uid 89); 28 Oct 2016 17:48:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 28 Oct 2016 17:48:00 -0000 From: Joseph Myers To: Florian Weimer CC: Carlos O'Donell , Subject: Re: [PATCH] Add test for linking against most static libraries In-Reply-To: <6ca11c8d-678c-c41f-1a03-c8c5ec4c7df2@redhat.com> Message-ID: References: <20161028125742.928D7439942E0@oldenburg.str.redhat.com> <8b17140d-bbab-95c1-7458-7214f0e474ad@redhat.com> <9c9a0748-7101-a6a0-297e-106886589d81@redhat.com> <6ca11c8d-678c-c41f-1a03-c8c5ec4c7df2@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-10/txt/msg00555.txt.bz2 On Fri, 28 Oct 2016, Florian Weimer wrote: > On 10/28/2016 07:33 PM, Joseph Myers wrote: > > > > I'm going to commit the following immediate fix: > > > > > > 2016-10-28 Carlos O'Donell > > > > > > * elf/Makefile (CFALGS-tst-linkall-static): Define. > > > > That's not the right fix. The right way to address such issues is a > > wrapper header in include/. > > Is this for installed headers only? is an installed header. We want glibc source files and tests to include installed headers via the same paths a normal program built with installed headers would, so #include not #include . The way we achieve this is through the wrappers in include/, some of them trivial (e.g. cpio.h, an example of a wrapper added for testcase use for a similar issue), some less trivial. > I've been using the style for internal headers. That may be reasonable if a file in one directory wants to include an internal header from another (though I'd think an internal header used in more than one directory should move to include/), but this isn't a case of an internal header. It should have a wrapper that does #include , so nothing other than the wrapper needs to use that path. -- Joseph S. Myers joseph@codesourcery.com