From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93856 invoked by alias); 1 Nov 2016 11:13:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 93844 invoked by uid 89); 1 Nov 2016 11:13:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=iov, s390, mentions, UD:res_send.c X-HELO: relay1.mentorg.com Date: Tue, 01 Nov 2016 11:13:00 -0000 From: Joseph Myers To: Andreas Schwab CC: Carlos O'Donell , Florian Weimer , GNU C Library Subject: Re: [PATCH v4] Fix -Os related build and test failures. In-Reply-To: <87mvhjwod1.fsf@linux-m68k.org> Message-ID: References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com> <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com> <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> <428b3741-9228-68f3-76ec-d042e4075ded@redhat.com> <87mvhjwod1.fsf@linux-m68k.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00006.txt.bz2 On Tue, 1 Nov 2016, Andreas Schwab wrote: > On Okt 30 2016, Carlos O'Donell wrote: > > > diff --git a/resolv/res_send.c b/resolv/res_send.c > > index 6d46bb2..4ec8c1a 100644 > > --- a/resolv/res_send.c > > +++ b/resolv/res_send.c > > @@ -664,7 +664,7 @@ send_vc(res_state statp, > > a false-positive. > > */ > > DIAG_PUSH_NEEDS_COMMENT; > > - DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); > > + DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); > > int resplen; > > DIAG_POP_NEEDS_COMMENT; > > struct iovec iov[4]; > > That breaks powerpc and s390. > > res_send.c: In function 'send_vc': > res_send.c:668:6: error: 'resplen' may be used uninitialized in this function [-Werror=maybe-uninitialized] > int resplen; > ^~~~~~~ And the other change to the same file introduces a new use of DIAG_IGNORE_NEEDS_COMMENT with a comment that only mentions -Os. Was the intent to edit the latter use to be DIAG_IGNORE_Os_NEEDS_COMMENT, with the former one edited by mistake instead? -- Joseph S. Myers joseph@codesourcery.com