From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118411 invoked by alias); 1 Nov 2016 16:41:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 118380 invoked by uid 89); 1 Nov 2016 16:41:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=accompanied, syscalls X-HELO: relay1.mentorg.com Date: Tue, 01 Nov 2016 16:41:00 -0000 From: Joseph Myers To: Andreas Schwab CC: Adhemerval Zanella , Subject: Re: [PATCH 07/15] Use semget syscall for Linux implementation In-Reply-To: <87bmxzw6wn.fsf@linux-m68k.org> Message-ID: References: <1478010323-13076-1-git-send-email-adhemerval.zanella@linaro.org> <1478010323-13076-8-git-send-email-adhemerval.zanella@linaro.org> <87bmxzw6wn.fsf@linux-m68k.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00036.txt.bz2 On Tue, 1 Nov 2016, Andreas Schwab wrote: > On Nov 01 2016, Adhemerval Zanella wrote: > > > This patch add a direct call to semget syscall if it is defined by > > kernel headers. > > That does not mean that the running kernel provides it. Specifically, this sort of patch series needs to be accompanied by an analysis of when the relevant syscalls were added for each supported architecture (and subarchitecture for cases with multiple syscall tables for different ABNs). If present (in the syscall table as well as in asm/unistd.h) in the minimum kernel version, OK, otherwise you need appropriate __ASSUME_* conditionals (even if not present in the latest kernel, it might be added in future, so you should have those conditionals now to avoid breaking things when current glibc is compiled with future kernel headers). -- Joseph S. Myers joseph@codesourcery.com