From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128237 invoked by alias); 4 Nov 2016 13:33:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128187 invoked by uid 89); 4 Nov 2016 13:33:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=$CC, $cc, interest X-HELO: relay1.mentorg.com Date: Fri, 04 Nov 2016 13:33:00 -0000 From: Joseph Myers To: Chris Metcalf CC: Subject: Re: Library directories for tilegx In-Reply-To: <691b37f4-437f-67b5-5a0c-d5ce31ea1604@mellanox.com> Message-ID: References: <1e1c3a65-b62f-7736-3fb8-741aa6afe09f@mellanox.com> <691b37f4-437f-67b5-5a0c-d5ce31ea1604@mellanox.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00158.txt.bz2 On Thu, 3 Nov 2016, Chris Metcalf wrote: > On 11/3/2016 7:08 PM, Joseph Myers wrote: > > Incidentally, I found another issue in building: GCC has a tilegxbe-* > > target name for big-endian, but sysdeps/tile/preconfigure only handles > > tilegx, not tilegxbe. However, that's easy to work around by configuring > > glibc for a different triplet from GCC. > > Good point. I don't actually test tilegxbe; I don't think we ever had a lot > of interest in that version of the toolchain. I will try to remember to add > it next time I do tests, and I can push up a fix to preconfigure at that point > too (or feel free to push one yourself). Fix pushed thus. Handle tilegx* machine names. This patch makes sysdeps/tile/preconfigure handle tilegx* machine names instead of just plain tilegx. That matches GCC, and in particular allows a big-endian toolchain to use the tilegxbe-linux-gnu name when configuring both GCC and glibc. Tested with compilation for tilegxbe-linux-gnu, both 32-bit and 64-bit (building a subsequent GCC against that glibc still falls over because of both 32-bit and 64-bit libraries going in the lib directory, as noted at ). 2016-11-04 Joseph Myers * sysdeps/tile/preconfigure: Accept tilegx* instead of tilegx. diff --git a/sysdeps/tile/preconfigure b/sysdeps/tile/preconfigure index dfe050c..f3e5d7e 100644 --- a/sysdeps/tile/preconfigure +++ b/sysdeps/tile/preconfigure @@ -2,7 +2,7 @@ case "$machine" in tilepro) base_machine=tile machine=tile/tilepro ;; - tilegx) + tilegx*) base_machine=tile if $CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null | grep -q __LP64__; then machine=tile/tilegx/tilegx64 -- Joseph S. Myers joseph@codesourcery.com