From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40035 invoked by alias); 4 Nov 2016 17:26:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40020 invoked by uid 89); 4 Nov 2016 17:26:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 04 Nov 2016 17:26:00 -0000 From: Joseph Myers To: Steve Ellcey CC: Subject: Re: [PATCH] Speed up math/test-tgmath2.c In-Reply-To: <1478280156.4630.18.camel@caviumnetworks.com> Message-ID: References: <1477354555.8523.78.camel@caviumnetworks.com> <1478280156.4630.18.camel@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-1942665137-1478280355=:25235" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00188.txt.bz2 ---1152306461-1942665137-1478280355=:25235 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Content-length: 920 On Fri, 4 Nov 2016, Steve Ellcey wrote: > > +  return test_cos (vint1, vllong1) > > +  + test_fabs (vint1, vllong1) > > +  + test_conj (vint1, vllong1) > > +  + test_expm1 (vint1, vllong1) > > +  + test_lrint (vint1, vllong1) > > +  + test_ldexp (vint1, vllong1) > > +  + test_atan2 (vint1, vllong1) > > +  + test_remquo (vint1, vllong1) > > +  + test_pow (vint1, vllong1) > > +  + test_fma_1 (vint1, vllong1) > > +  + test_fma_2 (vint1, vllong1) > > +  + test_fma_3 (vint1, vllong1) > > +  + test_fma_4 (vint1, vllong1); You don't want to add up test results like that; you should OR them together instead, to avoid the potential for test results adding up to 77 and wrongly becoming UNSUPPORTED. (In this case of course there aren't enough tests to get to 77, but the principle applies that you should avoid the test return being a count of something.) -- Joseph S. Myers joseph@codesourcery.com ---1152306461-1942665137-1478280355=:25235--