From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111063 invoked by alias); 9 Nov 2016 21:38:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 111038 invoked by uid 89); 9 Nov 2016 21:38:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=murphy, yx, sk:float12, 18661-3 X-HELO: relay1.mentorg.com Date: Wed, 09 Nov 2016 21:38:00 -0000 From: Joseph Myers To: "Gabriel F. T. Gomes" CC: Subject: Re: [PATCH 3/8] float128: Add wrappers for IEEE functions. In-Reply-To: <1478716859-3246-4-git-send-email-gftg@linux.vnet.ibm.com> Message-ID: References: <1478716859-3246-1-git-send-email-gftg@linux.vnet.ibm.com> <1478716859-3246-4-git-send-email-gftg@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00362.txt.bz2 On Wed, 9 Nov 2016, Gabriel F. T. Gomes wrote: > From: "Paul E. Murphy" > > These are copied from the long double version. posix style > errors are assumed, and inlined. Where a function is not > defined by TS 18661-3, the wrapper is not implemented. I don't think float128-specific wrappers like this are appropriate. All these wrappers should be type-generic. If you put type-generic wrappers as math/w_*_template.c, will the existing wrappers with matherr support still take precedence for existing types? > diff --git a/sysdeps/ieee754/float128/w_acosf128.c b/sysdeps/ieee754/float128/w_acosf128.c > new file mode 100644 > index 0000000..cedbc98 > --- /dev/null > +++ b/sysdeps/ieee754/float128/w_acosf128.c > @@ -0,0 +1,35 @@ > +/* Copyright (C) 2016 Free Software Foundation, Inc. Descriptive comment as first line of every new file. > +/* > + * wrapper atan2f128(y,x) > + */ Comments need to follow the normal coding style. > +/* wrapper y0f128 */ > +_Float128 > +__y0f128 (_Float128 x) > +{ > + if (__builtin_expect (islessequal (x, 0) || isgreater (x, X_TLOSS), 0)) No TLOSS checks. That's only relevant for _LIB_VERSION != _POSIX_ in the original code. > +/* wrapper sqrtf128 */ > +_Float128 > +__sqrtf128 (_Float128 x) > +{ > + if (__builtin_expect (isless (x, 0), 0) && _LIB_VERSION != _IEEE_) No _LIB_VERSION checks in new wrappers. -- Joseph S. Myers joseph@codesourcery.com