From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120540 invoked by alias); 9 Nov 2016 22:13:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 120526 invoked by uid 89); 9 Nov 2016 22:13:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=floath, UD:float.h, float.h, __nanf128 X-HELO: relay1.mentorg.com Date: Wed, 09 Nov 2016 22:13:00 -0000 From: Joseph Myers To: "Gabriel F. T. Gomes" CC: Subject: Re: [PATCH 8/8] float128: Add wrappers to override ldbl-128 as float128. In-Reply-To: <1478716859-3246-9-git-send-email-gftg@linux.vnet.ibm.com> Message-ID: References: <1478716859-3246-1-git-send-email-gftg@linux.vnet.ibm.com> <1478716859-3246-9-git-send-email-gftg@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00369.txt.bz2 On Wed, 9 Nov 2016, Gabriel F. T. Gomes wrote: > +/* float.h constants. */ > +#include > +#undef HUGE_VALL HUGE_VALL is not a float.h constant. > +/* __nanl is actually a macro. */ > +#undef __nanl > +#define __nanl(str) __nanf128(str) Not since 2016-09-20 Paul E. Murphy * math/s_nanf.c: Remove __nanf undef. * math/s_nan.c: Remove __nan undef. * math/s_nanl.c: Remove __nanl undef. * sysdeps/generic/math_private.h (__nan): Remove macro override. (__nanf): Likewise. (__nanl): Likewise. it isn't. > +/* assume GCC >= 6.2 and use the type-generic builtin. */ > +#define __builtin_copysignl __builtin_copysign > +#define __builtin_signbitl __builtin_signbit __builtin_copysign is not and never has been type-generic (type-generic built-in functions don't support the return type depending on the argument type, so it couldn't possibly work as type-generic). You'll need to use __builtin_copysignf128 and map to __builtin_copysignq for older compilers (and for consistency I'd say use __builtin_signbitf128 similarly). -- Joseph S. Myers joseph@codesourcery.com