From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124273 invoked by alias); 10 Nov 2016 22:13:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 124257 invoked by uid 89); 10 Nov 2016 22:13:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Thu, 10 Nov 2016 22:13:00 -0000 From: Joseph Myers To: "Gabriel F. T. Gomes" CC: Subject: Re: [PATCH 7/8] float128: Add private _Float128 declarations for libm. In-Reply-To: <1478716859-3246-8-git-send-email-gftg@linux.vnet.ibm.com> Message-ID: References: <1478716859-3246-1-git-send-email-gftg@linux.vnet.ibm.com> <1478716859-3246-8-git-send-email-gftg@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00423.txt.bz2 The internal function declarations, hidden_proto calls etc. in this patch are another case that would best be macroized with only the macro definitions depending on float128 support. Especially these ones: > +/* Float128 variants. */ > +#if __USE_FLOAT128 > +extern _Float128 __ieee754_sqrtf128 (_Float128); > +extern _Float128 __ieee754_acosf128 (_Float128); [...] as the largest block of code repeating something done for other types. -- Joseph S. Myers joseph@codesourcery.com