From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74716-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 85383 invoked by alias); 14 Nov 2016 17:00:45 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 85121 invoked by uid 89); 14 Nov 2016 17:00:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1085
X-HELO: relay1.mentorg.com
Date: Mon, 14 Nov 2016 17:00:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Chris Metcalf <cmetcalf@mellanox.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Make tile's set_dataplane API compatibility-only
In-Reply-To: <1479142545-13207-1-git-send-email-cmetcalf@mellanox.com>
Message-ID: <alpine.DEB.2.20.1611141658550.1171@digraph.polyomino.org.uk>
References: <1479142545-13207-1-git-send-email-cmetcalf@mellanox.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-SW-Source: 2016-11/txt/msg00469.txt.bz2

On Mon, 14 Nov 2016, Chris Metcalf wrote:

> diff --git a/sysdeps/unix/sysv/linux/tile/set_dataplane.c b/sysdeps/unix/sysv/linux/tile/set_dataplane.c
> index 5a4bffe4f311..e2ea896e88d0 100644
> --- a/sysdeps/unix/sysv/linux/tile/set_dataplane.c
> +++ b/sysdeps/unix/sysv/linux/tile/set_dataplane.c
> @@ -23,9 +23,9 @@
>  #include <sys/dataplane.h>
>  #endif
>  
> -/* Request dataplane modes from the kernel. */
> +/* Request dataplane modes from the kernel (compatibility only). */
>  int
> -set_dataplane (int flags)
> +__old_set_dataplane (int flags)
>  {
>  #ifdef __NR_set_dataplane
>    return INLINE_SYSCALL (set_dataplane, 1, flags);
> @@ -34,3 +34,7 @@ set_dataplane (int flags)
>    return -1;
>  #endif
>  }
> +
> +#if SHLIB_COMPAT (libc, GLIBC_2_12, GLIBC_2_25)
> +compat_symbol (libc, __old_set_dataplane, set_dataplane, GLIBC_2_12);
> +#endif

I'd expect the function definition to be under the SHLIB_COMPAT 
conditional as well, so the object file has no code in the static libc.

-- 
Joseph S. Myers
joseph@codesourcery.com