From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93890 invoked by alias); 16 Nov 2016 18:45:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 93879 invoked by uid 89); 16 Nov 2016 18:45:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1540 X-HELO: relay1.mentorg.com Date: Wed, 16 Nov 2016 18:45:00 -0000 From: Joseph Myers To: Mike Frysinger CC: , Chung-Lin Tang Subject: Re: nios2 sys/cachectl.h includes nonexistent asm/cachectl.h In-Reply-To: <20161116053145.GM21655@vapier.lan> Message-ID: References: <20161116053145.GM21655@vapier.lan> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00584.txt.bz2 On Tue, 15 Nov 2016, Mike Frysinger wrote: > On 04 Nov 2016 21:37, Joseph Myers wrote: > > nios2 glibc compile-only test results include: > > > > FAIL: misc/check-installed-headers-c > > FAIL: misc/check-installed-headers-cxx > > > > This is because sys/cachectl.h includes asm/cachectl.h, and the Linux > > kernel has no such header. How is this meant to work? Should that > > #include just be removed? > > delete it for now. looks like they speced it out for future usage, > but haven't yet gotten around to it. the kernel will explicitly > throw an error if the |op| field is non-zero. This patch does that. Do not include asm/cachectl.h in nios2 sys/cachectl.h. The nios2 sys/cachectl.h includes a kernel header asm/cachectl.h, which does not exist, so causing the check-installed-headers tests to fail. This patch removes the include of a nonexistent header. Tested (compilation only) for nios2. 2016-11-16 Joseph Myers * sysdeps/unix/sysv/linux/nios2/sys/cachectl.h: Do not include . diff --git a/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h b/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h index 717e6ae..d4e6b2e 100644 --- a/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h +++ b/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h @@ -21,9 +21,6 @@ #include -/* Get the kernel definition for the op bits. */ -#include - __BEGIN_DECLS #ifdef __USE_MISC -- Joseph S. Myers joseph@codesourcery.com