From: Joseph Myers <joseph@codesourcery.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] extras: New test/build infrastructure
Date: Fri, 25 Nov 2016 17:29:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611251722360.12591@digraph.polyomino.org.uk> (raw)
In-Reply-To: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com>
On Fri, 25 Nov 2016, Florian Weimer wrote:
> I do not propose bulk migration at this point. Some obscure use cases are not
> supported by the exported hooks.
I agree with the other comments about naming this something like
libtest-support.a (and naming headers, directories accordingly).
I think there would be clear advantages to setting things up so that all
existing tests can use the new code with no changes at all. That is, make
test-skeleton.c look more or less like your extras/test-skeleton.c, with
additional code to handle any missing pieces (e.g.
int
test_function (int argc, char **argv)
{
return TEST_FUNCTION;
}
to handle existing TEST_FUNCTION definitions without needing changes to
individual tests). If a slightly different interface is preferred, then
individual tests could be converted to that afterwards.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-11-25 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 15:59 Florian Weimer
2016-11-25 16:14 ` Zack Weinberg
2016-11-25 17:11 ` Andreas Schwab
2016-11-25 17:46 ` Florian Weimer
2016-11-25 17:45 ` Florian Weimer
2016-11-25 18:44 ` Zack Weinberg
2016-11-25 18:49 ` Florian Weimer
2016-11-25 16:16 ` Florian Weimer
2016-11-25 17:29 ` Joseph Myers [this message]
2016-11-25 17:48 ` Florian Weimer
2016-11-25 18:24 ` Joseph Myers
2016-11-25 19:26 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611251722360.12591@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).