From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31926 invoked by alias); 25 Nov 2016 17:29:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 31906 invoked by uid 89); 25 Nov 2016 17:29:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 25 Nov 2016 17:29:00 -0000 From: Joseph Myers To: Florian Weimer CC: GNU C Library Subject: Re: [PATCH] extras: New test/build infrastructure In-Reply-To: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> Message-ID: References: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00934.txt.bz2 On Fri, 25 Nov 2016, Florian Weimer wrote: > I do not propose bulk migration at this point. Some obscure use cases are not > supported by the exported hooks. I agree with the other comments about naming this something like libtest-support.a (and naming headers, directories accordingly). I think there would be clear advantages to setting things up so that all existing tests can use the new code with no changes at all. That is, make test-skeleton.c look more or less like your extras/test-skeleton.c, with additional code to handle any missing pieces (e.g. int test_function (int argc, char **argv) { return TEST_FUNCTION; } to handle existing TEST_FUNCTION definitions without needing changes to individual tests). If a slightly different interface is preferred, then individual tests could be converted to that afterwards. -- Joseph S. Myers joseph@codesourcery.com