From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11656 invoked by alias); 25 Nov 2016 18:24:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11644 invoked by uid 89); 25 Nov 2016 18:24:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1597 X-HELO: relay1.mentorg.com Date: Fri, 25 Nov 2016 18:24:00 -0000 From: Joseph Myers To: Florian Weimer CC: GNU C Library Subject: Re: [PATCH] extras: New test/build infrastructure In-Reply-To: <08a9e327-a42c-a1d4-dadc-4dddd15e3183@redhat.com> Message-ID: References: <9426ee75-3e45-6cde-b659-567398007a32@redhat.com> <08a9e327-a42c-a1d4-dadc-4dddd15e3183@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg00939.txt.bz2 On Fri, 25 Nov 2016, Florian Weimer wrote: > > I think there would be clear advantages to setting things up so that all > > existing tests can use the new code with no changes at all. That is, make > > test-skeleton.c look more or less like your extras/test-skeleton.c, with > > additional code to handle any missing pieces (e.g. > > Can you clarify what the goal is? If the > > #include "../test-skeleton.c" > > is at the end, it shall be possible to replace it with > > #include > > ? Or do you want me to replace test-skeleton.c with a version which already > includes ? (All names subject to revision.) I would like test-skeleton.c to either include extras/test-skeleton.c, or have essentially its contents in your patch, so that existing tests don't need changing at all to use the new facilities. (This implies making your intrastructure support all the facilities test-skeleton.c does.) This should work regardless of where in the test sources test-skeleton.c is included. (If there are a few tests for which full compatibility is hard, the patch might fix those at the same time as making the changes to test-skeleton.c. But unchanged tests should use the new facilities and the number of tests that need changing to make that so should be as few as possible.) (Changing all tests later to use a different name from "../test-skeleton.c" is fine, but I think such a global change to all tests' sources is best kept out of the initial patch.) -- Joseph S. Myers joseph@codesourcery.com