From: Joseph Myers <joseph@codesourcery.com>
To: Steve Ellcey <sellcey@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/2] Enable ILP32 mode on aarch64, update abilist files
Date: Wed, 30 Nov 2016 00:12:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611300001350.3451@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1480445388.14808.16.camel@caviumnetworks.com>
Please go through all the previous review comments on previous iterations
of ILP32 support (back to 2014) and make sure they are addressed. Some
haven't been.
New comment: please include an addition of ILP32 builds, both LE and BE,
to build-many-glibcs.py.
Possibly new comment: basing on top of Adhemerval's sysvipc consolidation
<https://sourceware.org/ml/libc-alpha/2016-11/msg00284.html> would be
better than adding new versions of various sysvipc files (if you think you
still need new versions after that patch, you need to work with Adhemerval
on making it more general).
Examples of old comments, not necessarily exhaustive: use 10.0.0 as
arch_minimum_kernel until the required changes are actually in Linus's
tree; descriptive comments before copyright notices on each new C file;
GLIBC_2.25 as minimum symbol version (or GLIBC_2.26 if it doesn't get in
within the next month).
Also make sure comments at top of source files are accurate; if you copied
a sysdeps/gnu file, don't keep the "GNU version." description, make it
reflect how it's now AArch64-specific.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-11-30 0:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:50 Steve Ellcey
2016-11-29 18:53 ` Steve Ellcey
2016-11-30 0:12 ` Joseph Myers [this message]
2016-11-30 12:24 ` Adhemerval Zanella
2016-11-30 13:01 ` Joseph Myers
2016-11-30 13:20 ` Adhemerval Zanella
2016-12-01 5:13 ` Yury Norov
2016-12-02 18:34 ` Steve Ellcey
2016-12-02 19:08 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611300001350.3451@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=sellcey@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).