From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125081 invoked by alias); 30 Nov 2016 00:12:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 125070 invoked by uid 89); 30 Nov 2016 00:12:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=month X-HELO: relay1.mentorg.com Date: Wed, 30 Nov 2016 00:12:00 -0000 From: Joseph Myers To: Steve Ellcey CC: Subject: Re: [PATCH 1/2] Enable ILP32 mode on aarch64, update abilist files In-Reply-To: <1480445388.14808.16.camel@caviumnetworks.com> Message-ID: References: <1480445388.14808.16.camel@caviumnetworks.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2016-11/txt/msg01078.txt.bz2 Please go through all the previous review comments on previous iterations of ILP32 support (back to 2014) and make sure they are addressed. Some haven't been. New comment: please include an addition of ILP32 builds, both LE and BE, to build-many-glibcs.py. Possibly new comment: basing on top of Adhemerval's sysvipc consolidation would be better than adding new versions of various sysvipc files (if you think you still need new versions after that patch, you need to work with Adhemerval on making it more general). Examples of old comments, not necessarily exhaustive: use 10.0.0 as arch_minimum_kernel until the required changes are actually in Linus's tree; descriptive comments before copyright notices on each new C file; GLIBC_2.25 as minimum symbol version (or GLIBC_2.26 if it doesn't get in within the next month). Also make sure comments at top of source files are accurate; if you copied a sysdeps/gnu file, don't keep the "GNU version." description, make it reflect how it's now AArch64-specific. -- Joseph S. Myers joseph@codesourcery.com