* Add missing hidden_def (__sigsetjmp) [committed]
@ 2016-12-01 20:50 Joseph Myers
2016-12-02 7:26 ` Florian Weimer
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2016-12-01 20:50 UTC (permalink / raw)
To: libc-alpha
This patch adds the missing hidden_def (__sigsetjmp) on various
architectures that were failing to build (as noted in
<https://sourceware.org/ml/libc-alpha/2016-11/msg01124.html>).
Tested (compilation only) with build-many-glibcs.py. Committed.
2016-12-01 Joseph Myers <joseph@codesourcery.com>
* sysdeps/alpha/setjmp.S (__sigsetjmp): Use hidden_def.
* sysdeps/hppa/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/mips/mips64/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/mips/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/sh/sh3/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/sh/sh4/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/sparc/sparc32/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/tile/setjmp.S (__sigsetjmp): Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc64/setjmp.S (__sigsetjmp):
Likewise.
diff --git a/sysdeps/alpha/setjmp.S b/sysdeps/alpha/setjmp.S
index e85bd52..8ce5200 100644
--- a/sysdeps/alpha/setjmp.S
+++ b/sysdeps/alpha/setjmp.S
@@ -96,6 +96,7 @@ $sigsetjmp_local:
#endif
END(__sigsetjmp)
+hidden_def (__sigsetjmp)
/* Put these traditional entry points in the same file so that we can
elide much of the nonsense in trying to jmp to the real function. */
diff --git a/sysdeps/hppa/setjmp.S b/sysdeps/hppa/setjmp.S
index cdf6514..0cc830f 100644
--- a/sysdeps/hppa/setjmp.S
+++ b/sysdeps/hppa/setjmp.S
@@ -70,3 +70,4 @@ __sigsetjmp:
b __sigjmp_save
nop
.procend
+hidden_def (__sigsetjmp)
diff --git a/sysdeps/mips/mips64/setjmp.S b/sysdeps/mips/mips64/setjmp.S
index e72eaa7..a3afd9c 100644
--- a/sysdeps/mips/mips64/setjmp.S
+++ b/sysdeps/mips/mips64/setjmp.S
@@ -42,3 +42,4 @@ ENTRY (__sigsetjmp)
#endif
jr t9
END (__sigsetjmp)
+hidden_def (__sigsetjmp)
diff --git a/sysdeps/mips/setjmp.S b/sysdeps/mips/setjmp.S
index 8ddbf19..f2833e4 100644
--- a/sysdeps/mips/setjmp.S
+++ b/sysdeps/mips/setjmp.S
@@ -44,3 +44,4 @@ ENTRY (__sigsetjmp)
j __sigsetjmp_aux
#endif
END (__sigsetjmp)
+hidden_def (__sigsetjmp)
diff --git a/sysdeps/sh/sh3/setjmp.S b/sysdeps/sh/sh3/setjmp.S
index 4e484c3..9745ec2 100644
--- a/sysdeps/sh/sh3/setjmp.S
+++ b/sysdeps/sh/sh3/setjmp.S
@@ -78,3 +78,4 @@ ENTRY (__sigsetjmp)
# endif
#endif
END (__sigsetjmp)
+hidden_def (__sigsetjmp)
diff --git a/sysdeps/sh/sh4/setjmp.S b/sysdeps/sh/sh4/setjmp.S
index b424465..934292a 100644
--- a/sysdeps/sh/sh4/setjmp.S
+++ b/sysdeps/sh/sh4/setjmp.S
@@ -87,3 +87,4 @@ ENTRY (__sigsetjmp)
# endif
#endif
END (__sigsetjmp)
+hidden_def (__sigsetjmp)
diff --git a/sysdeps/sparc/sparc32/setjmp.S b/sysdeps/sparc/sparc32/setjmp.S
index 6d0989f..cef5986 100644
--- a/sysdeps/sparc/sparc32/setjmp.S
+++ b/sysdeps/sparc/sparc32/setjmp.S
@@ -53,6 +53,7 @@ ENTRY (__sigsetjmp)
call __sigjmp_save
mov %g1, %o7
END(__sigsetjmp)
+hidden_def (__sigsetjmp)
weak_extern(_setjmp)
weak_extern(setjmp)
diff --git a/sysdeps/tile/setjmp.S b/sysdeps/tile/setjmp.S
index 4f08e9a..7bcbc3f 100644
--- a/sysdeps/tile/setjmp.S
+++ b/sysdeps/tile/setjmp.S
@@ -44,3 +44,4 @@ ENTRY(__sigsetjmp)
j plt(__sigjmp_save)
jrp lr /* Keep the backtracer happy. */
END(__sigsetjmp)
+hidden_def (__sigsetjmp)
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/setjmp.S b/sysdeps/unix/sysv/linux/sparc/sparc64/setjmp.S
index 1be32d9..01661cc 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/setjmp.S
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/setjmp.S
@@ -61,6 +61,7 @@ __sigsetjmp_local:
mov %g1, %o0
END(__sigsetjmp)
+hidden_def (__sigsetjmp)
weak_extern(_setjmp)
weak_extern(setjmp)
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Add missing hidden_def (__sigsetjmp) [committed]
2016-12-01 20:50 Add missing hidden_def (__sigsetjmp) [committed] Joseph Myers
@ 2016-12-02 7:26 ` Florian Weimer
0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2016-12-02 7:26 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
On 12/01/2016 09:50 PM, Joseph Myers wrote:
> This patch adds the missing hidden_def (__sigsetjmp) on various
> architectures that were failing to build (as noted in
> <https://sourceware.org/ml/libc-alpha/2016-11/msg01124.html>).
>
> Tested (compilation only) with build-many-glibcs.py. Committed.
>
> 2016-12-01 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/alpha/setjmp.S (__sigsetjmp): Use hidden_def.
> * sysdeps/hppa/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/mips/mips64/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/mips/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/sh/sh3/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/sh/sh4/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/sparc/sparc32/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/tile/setjmp.S (__sigsetjmp): Likewise.
> * sysdeps/unix/sysv/linux/sparc/sparc64/setjmp.S (__sigsetjmp):
> Likewise.
Thanks for cleaning this up.
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-02 7:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-01 20:50 Add missing hidden_def (__sigsetjmp) [committed] Joseph Myers
2016-12-02 7:26 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).