From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-75855-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 993 invoked by alias); 14 Dec 2016 00:47:45 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 979 invoked by uid 89); 14 Dec 2016 00:47:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:899
X-HELO: relay1.mentorg.com
Date: Wed, 14 Dec 2016 00:47:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 3/8] float128: Add wrappers for IEEE functions.
In-Reply-To: <20161209192413.683ac72d@keller>
Message-ID: <alpine.DEB.2.20.1612140045040.20484@digraph.polyomino.org.uk>
References: <1478716859-3246-1-git-send-email-gftg@linux.vnet.ibm.com> <1478716859-3246-4-git-send-email-gftg@linux.vnet.ibm.com> <alpine.DEB.2.20.1611092132390.6428@digraph.polyomino.org.uk> <20161205144754.4c0c7c13@keller.br.ibm.com>
 <alpine.DEB.2.20.1612051829010.19059@digraph.polyomino.org.uk> <20161207173544.36123848@keller.br.ibm.com> <alpine.DEB.2.20.1612072133300.28567@digraph.polyomino.org.uk> <20161209192413.683ac72d@keller>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-SW-Source: 2016-12/txt/msg00483.txt.bz2

On Fri, 9 Dec 2016, Gabriel F. T. Gomes wrote:

> On Wed, 7 Dec 2016 21:47:28 +0000
> Joseph Myers <joseph@codesourcery.com> wrote:
> 
> > For log1p, I'd expect the template file to use -1 (or M_LIT (-1.0) in the 
> > islessequal call) rather than the double value -1.0.  And I'd hope that 
> > you can remove the ldbl-128ibm/w_log1pl.c and ldbl-64-128/w_log1pl.c files 
> > completely and the generated file will do the right thing automatically.
> 
> I attached a new version with the suggested changes.

This patch is OK.

(For the record for anyone wondering: in this case it's correct that the 
template does not use M_LIBM_NEED_COMPAT, because the compat symbol for 
long double = double on architectures where it changed points directly to 
the underlying implementation that does not set errno.)

-- 
Joseph S. Myers
joseph@codesourcery.com