From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97098 invoked by alias); 7 Feb 2017 16:41:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97055 invoked by uid 89); 7 Feb 2017 16:41:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*M:4464 X-HELO: relay1.mentorg.com Date: Tue, 07 Feb 2017 16:41:00 -0000 From: Joseph Myers To: Rical Jasan CC: , , Subject: Re: [PATCH v2 3/5] manual: Add new header and standards annotations. In-Reply-To: <0d5758f3-52bb-31cb-21e2-d218ace98065@pacific.net> Message-ID: References: <20161206105525.21117-1-ricaljasan@pacific.net> <20161206105525.21117-4-ricaljasan@pacific.net> <665e49d4-dfa0-e14d-a793-d4acdca8e617@pacific.net> <7dd6da88-601f-e6f2-1f16-c24d7fdf84e2@pacific.net> <8c01ffc4-fcee-d584-bfab-d74a0b552b77@pacific.net> <8e8b0d56-b001-1870-1b5c-9895a1301c07@pacific.net> <0d5758f3-52bb-31cb-21e2-d218ace98065@pacific.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-02/txt/msg00128.txt.bz2 On Mon, 6 Feb 2017, Rical Jasan wrote: > The commit message in [1], however, contains the rationale behind these > changes, which is lost if I break the chapters apart and give specifics. > If I were to include the rationale in every chapter, that would be > overly redundant. I feel the patches speak for themselves, given the > rationale, but I also understand the need to ease review for larger diffs. I'd say the first commit should give the general description of the issues / design of changes being made, then describe what's being done in that particular commit. Subsequent ones might then refer back to the first commit / submission of that patch for details of the overall issue / changes. -- Joseph S. Myers joseph@codesourcery.com